Test case:

http://develop.twiki.org/~develop/cgi-bin/search/Sandbox?search=testing

shows summaries with linked text.

Possibly caused by removing nop tags early, then render text again?

-- PTh

no, this was an intentional enhancement.

-- SD

I call this a bug since it is a spec change that might break existing apps. Consider for example if the RSS feeds summary suddenly contain links. Better to add a new switch to $summary() if you want that functionality, such as $summary(render) (which should be treated as an enhancement).

-- PTh

RSS feeds are one of the major reasons i made this change! if you look at almost any modern blog with a modern blog reader, you get html - the feed sends escaped html, and so does twiki now)

Its a change that should be harmless, and had been desired for years - I finally bit the bullet and made summary more wikilike - if we always have to add new syntax to improve things, twiki's going to get even more crufty than it already is - we really could move quite a bit of old syntax into a legacy package...

SD

I documented this change in DakarReleaseNotes. SVN 1801

CC

Reopening this. Please compare the result of WebSearch and plain search script. Should look the same.

- PTh

Peter, you assert above that this change might break an existing TWiki application. It's an obvious and attractive enhancement, so it would be really good to know what application you have in mind that it might break? Perhaps if you could illustrate how it can break something important, then Sven might feel motivated to revert all his hard work. Or is it just that you feel search should just be a CGI API to %SEARCH? Otherwise I can't understand your reasoning.....?

CC

One feature at a time please. There is no need to revert the hard work, I created enhancement request Item1376: Add new $summary(render) to FormattedSearch. See that topic why we should not change the spec of $summary.

Actually, thinking it over, TWiki applications are unlikely to use the search script, so there is a low risk that this bug Item1307 breaks them. TWiki applications make heavy use of %SEARCH{}%, and the $summary() in %SEARCH{}% works as expected (except for the small bug Item1306, Web prefix not removed from summary).

This Item1307 is a bug since one expect that the output of search script with =search?format=something and %SEARCH{ format="something" }% (delivered by view script) would be identical.

-- PTh

search and WebSearch now seem to uptput the same thing, but truly is all fakery. they 2 of them do not seem to use the same code paths.

Worse, the 1-2 weeks work i did to make html rendering working for xml, html plain text and so in have been removed and killed over the last 3 months, so i'm giving up.

svn:8227

SD