This is needed so that people can discover it in the TWikiSkinBrowser
No it isn't. It's in twikiplugins/ClassicSkin/data/TWiki, is included in the MANIFEST of that contrib, and ClassicSkin
is listed in tools/MANIFEST as installed by default.
It was missing from the last beta because of a bug in the BuildContrib
, which has since been fixed.
How come it is not listed in TWikiSkinBrowser
here on develop.twiki.org? The topic does not exist either. It is also not listed on my local install (but exists in twikiplugins/ClassicSkin/data/TWiki).
Is your local install beta5? Or SVN? Did you pseudo-install? I don't know why it isn't listed here; that's wierd. Sven? I noticed there were some merge conflicts on develop.twiki.org again.....?
Yes, I can see the classic skin now after running pseudo-install.
I understand now my confusion. I just realized that this is now an actual skin. It used to be the default templates labelled as "skin" so that people can see it in the TWikiSkinBrowser
. If you activate a non-existing foobar skin, it falls back to the default template. The Cairo version skin has this description: "This is not really a skin. It is the set of default templates, shown if no skin is activated. The default templates are part of every TWiki distribution."
Now it is turned into a real skin, there are files like
I do not understand why this was necessary. If an invalid skin is specified, or a script of a non-existing template of a skin, it falls back to the default template. That is, we need to maintain now the default templates and the classic skin instead of just the default templates.
For ease of maintenance, would'nt it be better to merge the classic skin templates into the default templates?
No. The classic skin has grown amorphously over time, and has reached a stage where it is horribly complex, and a poor basis for the development of new skins. We have discussed for some time implementing a much simpler css-based default skin that is more attractive, easier for people to understand, and base new themes and skins off. The reason ClassicSkin was split out was to make sure we didn't lose
any of it we start simplifying the default templates.