I've attached a file style#1.css. Now FILENAME tells me this is file style, so some part is missing from the name.

The url parameters are: ?filename=style#1.css&revInfo=1

FILEPATH has the same problem, it says: http://visiblearea.com/devtwiki/pub/Sandbox/BigImage/style

AC

Moving/renaming is also not possible, because param style is passed to that page and twiki thinks file style does not exist - which is right.

AC

I just tried this on TWiki0400 branch, with a file called blah#de#blah.gif, and it works fine. DIscarding pending a clearer report (e.g. what are FILENAME and FILEPATH and where are they used?)

CC

http://develop.twiki.org/~develop/cgi-bin/attach/Bugs/Item1724?filename=test#1.txt&revInfo=1

AC

Sounds like a simple problem with URL-encoding, perhaps? Normally the # suggests a label in the URL, probably the manage link (and others?) should just be URL-encoded to work correctly.

-- SP

Is it the locale, possibly? When I hover over Arthur's link above, I see the correct file; when I click on it, I get the file. I can't see any problem....

CC

Well, you can get the latest revision of the file OK, but the revision table is empty at the manage screen (you can't get to previous versions).

I'm attaching a patch, but I'm a bit unweary of two things:

1. Why doesn't TWiki::urlEncode encode the # - I'd say it should?
2. Is this I18N-safe "enough" to be committed?

-- SP

Oh, I see. The problem is simply that the templates include an unencoded URL. All that's needed is to put %ENCODE around the %A_FILE in attachtables.tmpl. # is URL encoded just fine.

SVN 9039, 9040 (already merged)

CC

*Sigh* Why didn't I think of that

Excellent, thanks!

-- SP

With the updated skin, this needs a second look.

1. Direct link in "Update attachment .." in the header doesn't work (The requested URL was not found on this server)
2. Move link doesn't work ("Attachment does not exist")
3. Delete link doesn't work ("Attachment does not exist")

-- SP

Attachment filename seemed to have accidentially been removed from the forms, added again.

SVN 9090, 9091 + 9093.

-- SP

Merged to TWiki4, SVN 9124

CC

9094 + 9125 ready for merge.

I believe svn log should be used in preference to the listed SVN revisions. "Hidden" commits like 9094 will probably cause some trouble later if never merged.

-- SP

The whole TWiki:Plugins.PatternSkin stuff is already merged, so I'm closing this one.

-- RA

Closed with the release of 4.0.2

KJL