• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

When clicking on the "Printable" action in the view mode, the resultant printable view is generated without considering any URL parameters that might have been used to generate the original view. Thus the printable view might look nothing like the view the user wanted to print (if the URL parameters were important in rendering the view).


This feature is discussed some in TWiki:Codev.PrintviewOfParameterisedSearch.

Item2453 is another variance on preserving parameters.

-- SP

Changing this back to normal. It is not a release blocker but more of a feature request (discussion in TWiki:Codev.WhatIsIn04x01).

-- SP

I believe this is a release blocker... The current behavior is not correct and not acceptable... I have submitted a solution elsewhere, so we should just discuss whether this is appropriate...

-- TW

Fixed this by affixing query parameters to printview. However, there could be some refactoring with the TOC code which also needs these query parameters (see Item2453). Look for SMELL in lib/TWiki/UI/View.pm.

Further, I discovered that there is a tag %QUERYPARAMS% in TWiki.pm which does something similar to what needs to be done here. Unfortunately, little benefit in factorizing. This tag is used in templates for passing the url parameters across a script invocation (in particular, in oops )... -- TW


Renamed the intermediate tag to %QUERYPARAMSTRING% for consistency.

I am not happy with the duplication of code in TWiki.pm and TWiki/UI/View.pm and having to compute the parameters passed into a query twice. But operating on the strings to make it all work if we factorize this seems even slower.

Probably the right thing to do is to cache the query parameters as they are needed also in %QUERYPARAMS% but I am not sure whether it is even worth it in terms of speed. -- TW

4.1.0 released

KJL

ItemTemplate
Summary Printable looses URL parameters
ReportedBy TWiki:Main.ThomasWeigert
Codebase 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, ~twiki4
SVN Range Thu, 29 Jun 2006 build 10750
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 11797 11841 11843
TargetRelease minor
Edit | Attach | Watch | Print version | History: r17 < r16 < r15 < r14 < r13 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r17 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback