• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

I don't know how long this has been failing, but it noticed it today before I started working on save script modifications to solve Item252.

It is somewhat strange, as the save script does the right thing upto the call to $store->saveTopic. The form is TestForm3 at this point. But somehow, after reading the saved topic the form is TestForm1 which was what was there before the save.

(Note that the changes to Item252 did not cause this defect.)


Is there something weird in your test environment? It passes fine in mine....

But I see an error in test_templateTopicWithMeta that does appear to be a result of your changes

There was 1 failure:
1) /home/twiki/DEVELOP/test/unit/SaveScriptTests.pm:445 - test_templateTopicWithMeta(SaveScriptTests)
<undef> unexpected
(I updated the test to try and make it clearer, so svn up first)

CC


Hmmm. My tests give totally different results. Also, I don't see your update to the test script in SVN. Something is really out of synch here... I am attaching the output of the test script. --TW


Note further that line 446 in SaveScriptTests is the final closing brace of the test case. The error message does not quite make sense. --TW


That last was my fault, I modified it to make the error clearer and didn't check it in; there now.

I do not see an error on line 390. My code is almost identical to DEVELOP, though there is one minor change in Func but it should be irrelevant to this.

CC


I see your mods now to SaveScriptTests but still my result of running this unit test is as shown in run1.log using a completely updated develop installation without any changes. --TW


I still don't see the error, and from reading the test code I can't see how what you describe it ever possible. The topic in question is being written immediately beforehand, and TestForm1 doesn't even enter the picture. Is it possible that you have an existing file sitting around blocking the tests? Is the topic file in question getting written? Note you can use:
print `cat $TWiki::cfg{dataDir}/$testweb/$testtopic.txt`;
to inspect the topic from the test. You can obviously ls -l it the same way. CC
I'm going to have to discard this; the save script tests have changed a lot. Please re-open it if you still see the error. CC
I cannot see how this test script could have worked for you. I have fixed the test script and checked it in as SVN 6231. Waiting for your approval, please close if ok. --TW
It didn't - we just overlapped, confused eachother, and then independently fixed the bugs :-/

Thanks for the fix! All works for me, now.

CC

ItemTemplate
Summary unit test SaveScriptTests, test_templateTopicWithMeta fails
ReportedBy ThomasWeigert
Codebase

AppliesTo Engine
Priority Normal
CurrentState Closed
WaitingFor

Checkins 6088 6101 6231
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatlog run1.log r0 manage 2.2 K 2005-08-20 - 01:54 ThomasWeigert  
Edit | Attach | Watch | Print version | History: r14 < r13 < r12 < r11 < r10 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r14 - 2005-09-02 - ThomasWeigert
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback