Item2856 < Bugs

• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use

Item7848 for generic doc work for TWiki-6.1.1. Use

Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

Given

* Set WEBFORMS = SomeTWikiForm, AnotherWeb.AnotherTWikiForm,

in WebPreferences AnotherTWikiForm is not clickable in "changeform" but SomeTWikiForm because the code checks existence of the topic AnotherWeb.AnotherTWikiForm in the current web instead of checking for AnotherTWikiForm in AnotherWeb.

Here is the patch

-- TWiki/UI/ChangeForm.pm      (revision 11463)
+++ TWiki/UI/ChangeForm.pm      (working copy)
@@ -80,7 +80,9 @@
            };
         $props->{checked} = 'checked' if $form eq $formName;
         $formList .= CGI::input( $props );
-        my $formLabelContent = '&nbsp;' . ( $store->topicExists( $web, $form ) ? '[['.$form.']]' : $form );
+       my ($formWeb, $formTopic) = $session->normalizeWebTopicName($web, $form);
+        my $formLabelContent = '&nbsp;' . ( $store->topicExists( $formWeb, $formTopic ) ?
+         '[['.$formWeb.'.'.$formTopic.']['.$form.']]' : $form );
         $formList .= CGI::label( { for => $formElemId}, $formLabelContent );
     }
     $page =~ s/%FORMLIST%/$formList/go;

Thanks for fixing an annoying little bug which I have also encountered and thought was a lack of feature. Adding to hotfix-4.0.4-4

KJL

ItemTemplate
Summary	make TWikiForms defined in another web clickable in "changeform"
ReportedBy	TWiki:Main.MichaelDaum
Codebase	~twiki4
SVN Range	TWiki-4.1, Mon, 11 Sep 2006, build 11460
AppliesTo	Engine
Component
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	11467
TargetRelease	patch

Raw edit | More topic actions

Topic revision: r5 - 2006-11-14 - KennethLavrsen

Account
- Log In

Edit
Attach