• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Hello,

Using TWIKI-4 SVN, and in lib/Twiki/Configure/Checker.pm, there is a typo that prevents it from working properly.

In the first section of the checkPerlModules functions, there is an if statement, if (ref($_[0])) {, like that. Later on, right after, there's a missing hash symbol % for the $mods which causes a "software error" and it bombs out after the CGI env. stuff.

full text, error itself is on line 187:

BEFORE:

sub checkPerlModules {
    my $this = shift;
    my $mods;
    if (ref($_[0])) {
        $mods = $_[0];
    } else {
        %$mods = (@_);
    }

AFTER:

sub checkPerlModules {
    my $this = shift;
    my $mods;
    if (ref($_[0])) {
        %$mods = $_[0];
    } else {
        %$mods = (@_);
    }


Interesting; possibly something to do with your perl version, because I don't get this error. The code is right; if $_[0] is a reference to a hash, then $mods is pointed at the same hash; the % sign is not needed, and is wrong. The error you are seeing must be the result of the call; can you share the stack trace please?

Discarding until sufficient information provided to allow the error to be reproduced.

CC

ItemTemplate
Summary Typo In Configure/Checker.pm Causes Software Error
ReportedBy TWiki:Main.EricCote
Codebase ~twiki4
SVN Range TWiki-4.1, Tue, 12 Sep 2006, build 11476
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2006-09-16 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback