• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The recent merge of Twisty related code from DEVELOP to TWiki4 branch has also merged in the long known bugs.

Internet Explorer reports javascript errors now and the Show Attachments / Hide Attachments is no longer working. Both links are shown.

I see this error both here on Bugs and on my test server.

The Javascript error says (in IE)

Line 388 Error 'length' is null or not an object, Code 0

On Bugs web but not on my test server I also see TWisty related tags.

On bugs I have additional javascript errors. You cannot copy paste these messages from the IE message window so I will not type them here. Please test with IE and click on the error icon in the lower left to see them for yourself.

KJL


PatternSkin -> needs TwistyPlugin -> TwistyContrib -> needs BehaviourContrib. Some of these are not installed here. I am not sure if that will be automatic once the dependencies are in place. I also don't know if I have all dependencies correct now.

AC

I have activated BehaviourContrib on my test server and I still have Javascript errors and the Attachment twisties still do not work - both in IE and in Firefox.

KJL

Added check agains null pointer dereference in _getKeyValue() of twiki.js. This fixes at least partially the two links being shown. Still initialization of the twisty state is broken as it does not set states according to cookies when using remember=on.

MD

Thanks Michael. I will have a further look.

I propose to remove twiki.compressed.js for a while because it is a pain debugging a 1 line script.

AC

There also a couple of template changes that needed to be merged. On my test site it works now without js errors. Let me know if it works for you too.

AC

On my testserver I still have javascript errors but only when the topic has an attachment and only IE reports them now.

And the attachment twisties still do not work. Not in IE and not in FF.

This is an example URL http://merlin.lavrsen.dk/twiki/bin/view/Myweb/AttachmentWorks. I still run a server updating from the TWiki4 SVN twice per hour (full and half hour).

I tried adding this to tools/manifest

!include twikiplugins/BehaviourContrib/lib/TWiki/Contrib/BehaviourContrib
!include twikiplugins/TwistyPlugin/lib/TWiki/Plugins/TwistyPlugin

I guess this is needed to get these two dependencies added to the built package. But this is not the reason for the error because I build with a pseudo-install with -link all. I have tried however with -link default and adding the two lines - just in case. But the problem is still there.

The minute you click on an attachment twisty they appear to work. When you reload the page you see both both the "Show attachments" and "Hide attachmentslinks" side by side again.

I also tried editing a page. The nice new feature that allows you to grow and shrink the edit window and change between monospace and proportional is gone on my test server.

KJL

Looks like TwistyPlugin.pm did not get through. New update, r. 11568.

AC

I still have a problem with the remembered state (reading from or writing to a cookie).

  • Should be fixed now (r. 11569).
AC

The twisty works but IE now reports a new Javascript error. It does not appear at initial page load, but comes when you click the attachment twisty.

Line: 336, Char: 2, Error: 'null' is null or not an object, Code 0.

KJL

Better now (r. 11599) ?

AC

Yes. Confirmed smile Also fixed the twisty jump to top issue.

Setting to closed since this bug is not to be mentioned on release note for 4.1 since it was not found in 4.0.4.

KJL

ItemTemplate
Summary Attachment twisties bugs from DEVELOP merged into TWiki4 branch
ReportedBy TWiki:Main.KennethLavrsen
Codebase ~twiki4
SVN Range TWiki-4.1, Tue, 19 Sep 2006, build 11536
AppliesTo Extension
Component PatternSkin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 11564 11567 11568 11569 11575 11599 11611
TargetRelease minor
Edit | Attach | Watch | Print version | History: r25 < r24 < r23 < r22 < r21 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r25 - 2006-09-27 - ArthurClemens
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback