• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
BulkResetPassword fails to display any completion message if you change more than 3 or 4 passwords at a time. Error reporting does not work with multiple updates.


Attempting to reset more than a couple of passwords results in a blank screen and a Page Cannot Be Displayed error. The password change e-mails ARE sent.

Problem is that TWiki::OopsException is being called with ALL the change information in the $message. This exceeds the maximum length of the GET parameter area and results in invalid page, possibly also Apache malformed header for script error.

Rough solution is to replace detail in $message with just a list of users when doing bulk registration. Here is a rough change to lib/TWiki/UI/Register.pm starting at line 486 with added lines flagged in comments--

    # Collect all messages into one string
    my $message = '';
    my $good = 1;
    my $user_count = 0; 	# added
    my $user_list = '';		# added
    foreach my $userName (@userNames) {
        $user_count++;		# added
        unless ( $user_list eq '' ) { $user_list .= ", "; } # added
        $user_list .= "$userName"; #added
        $good = $good &&
          _resetUsersPassword( $session, $userName, $introduction, \$message );
    }
    my $action = '';
    if ( $isBulk ) {	#added
        	# replace message with user list
        	$message = "Changed $user_count passwords: $user_list";
        }

Error handling/reporting logic appears to have been designed for a single update. If you have multiple updates, success and errors are NOT be reported correctly.


This is growing some months old, and Bulk code were touched a few times since.

Is this still a problem with 4.1.0?

-- SP

No feedback, so discarding under 30 day rule.

CC

ItemTemplate
Summary BulkResetPassword fails with more than 3 passwords; error reporting flawed.
ReportedBy TWiki:Main.ChuckEhrlich
Codebase 4.0.4
SVN Range TWiki-4.1, Sat, 23 Sep 2006, build 11571
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor TWiki:Main.ChuckEhrlich
Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2007-04-07 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback