• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
I have recently had problems with EditTablePlugin and traced it to TWiki::Plugins::EditTablePlugin::Core::parseFormat, line 210:
        $theFormat = TWiki::Func::expandCommonVariables( $theFormat, $theTopic, $theWeb );

Under certain circumstances, after this $theFormat has an extra newline appended, which results in that the table does not correctly reflect the value stored in the topic when we have select, checkbox, or similar restricted types, for the last entry in a row.

We either need to figure out why the extra newline is added, or remove it in parseFormat.

-- DanDascalescu - 23 Mar 2007: Does this also cause the last item in a 1-per-line radio button list to not be formatted? Test case below:

last radio button item not replaced by image


last radio button item not replaced by image

Tried this and it is true. Tried different smilies and same problem. An annoying error because you cannot use Twiki variable either. Limits the use of the plugin heaviliy. Confirmed.

Note - to see the problem simply hit the edit bottons below the tables.

-- TWiki:Main.KennethLavrsen - 03 Oct 2007

Was also raised in Item3800 which I have marked a duplicate.

Since more than one has reported this I think it is a very frequent annoyance and probably an easy regex fix for someone that knows the plugin. Raising to urgent.

KJL

The variables need a space on both sides to get expanded. This should be an easy fix. But normal text will get the extra spaces too, and that might not be desired. Take this example (rendered from my test code):

smile , frown item1 , item2

We could add the extra spaces only when a variable is used. But smilies have a loose syntax, so in that case a comparison table would be needed.

-- TWiki:Main.ArthurClemens - 17 Oct 2007

I will stick to the

<space>,</space>
syntax.

-- TWiki:Main.ArthurClemens - 18 Oct 2007

ItemTemplate
Summary EditTablePlugin format fails for last item
ReportedBy TWiki:Main.ThomasWeigert
Codebase 4.0.2, ~twiki4
SVN Range TWiki-4.1, Sun, 08 Oct 2006, build 11688
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:15333 TWikirev:15334
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback