• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

When I run bin/configure, I am seeing sections like the following:

Cwd3.01 installed. Version 3.05 Required for Required. Available from the CPAN archive.

3.01 installed. Version 3.05 Required for Required. Available from the CPAN archive.

...
Apache::Htpasswdnot installed. Optional, only required for ApacheHtpasswd password manager for Optional, only required for ApacheHtpasswd password manager

not installed. Optional, only required for ApacheHtpasswd password manager for Optional, only required for ApacheHtpasswd password manager

While I admit that the facts are correct, I doubt that it needs to be said so often. On the other hand, if a required module has a wrong version, I'd expect this to be shown as an error.

Apart from a simple superfluous concatenation in lib/TWiki/Configure/Checkers.pm this is due to a unclear specification between the data in tools/DEPENDENCIES and the parser in lib/TWiki/Configure/Checkers/CGISetup.pm.

The fix which I am going to check in changes tools/DEPENDENCIES to fit the expectations of the code. Maybe this is the wrong way around, but sub checkPerlModules is called from many places.


Darn. The fix is incomplete, and I can't figure out how to complete: Errors and warnings in the CGI Setup section are not properly summarized - maybe because the readonly sections aren't TWiki::Configure::Section objects?

haj


Seems OK now

CC


Much better, indeed. Thanks for fixing the usage texts much better than I did. There's still one minor thing, and a bigger one which I may have expressed incomprehensibly:

CGI Setup(read only)
Cwd
Error: 3.01 installed. Version 3.05 required for for base TWiki

Note that before I expand the table all I see is "CGI Setup (read only)" instead of "CGI Setup (read only) 1 error". If there are fatal errors, they must be visible in the CGI Setup section like in any other one. The minor issue is that it says "for for". (Back to status "new")

haj


Ok, here some results of tonight's analysis (it's still not fixed):

  • TWiki::Configure::UI has class variables to store the total number of errors and warnings, but they're never updated. So the summary block is never shown.
    • Fixed with r11721
  • There is a typo in bin/configure when these vars are finally checked (fixed with tonight's checkin).
  • bin/configure sets up an $eroot for read-only sections, but fills it with empty stubs only, and apparently never makes uses of it. Maybe that was the mechanism intended to keep track of accumulated errors?
    • The stubs are needed for counting errors, the roots aren't used.
  • TWiki::Configure::Root is a TWiki::Configure::Section is a TWiki::Configure::Item, but the constructors successively drop parameters: Root tries to create a Section with two parameters, but only one is used, and Section tries to create an Item with one parameter, which is dropped as well. The parameter used by Section to create a new Item is a class name, which scares me because I have no idea what the intention is.
    • Still unclear to me, but of no relevance to the item.
  • A new observation: There ought to be an error message that some of the files in bin are not executable. I can see that the path which sets the error message is executed during configure tracing, but no text is appearing in the output.
    • Fixed.

haj

Finally I've nailed it down. I hope I didn't break anything outside _actionConfigure

haj

ItemTemplate
Summary bin/configure is too noisy in CGI Setup section
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-4.1, Sun, 08 Oct 2006, build 11688
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 11691 11692 11701 11721
TargetRelease n/a
Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2006-10-15 - HaraldJoerg
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback