• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Since the last performance hacks to the TablePlugin, it only gets loaded into the TWikiEngine when the current topic includes a %TABLE tag. But once there's at least one tag found all TWikiTables are rendered by the TablePlugin (according to its default settings) and not only those that are preceeded by a %TABLE tag.

This can be resolved in two different ways:

  1. Either render all TWikiTables and therefore load the TablePlugin unconditionally
  2. or the TablePlugin should only take care of those tables it has been put on.

Personally, I'd opt for (2).


I'd opt for (2) as well. I hate it when it stomps tables.

Some people will hate it, because it means that "normal" tables are not sortable. Personally I think that's OK.

CC


SVN 6184 CC
Hm, that will definitely annoy many, cause one of the great features of the TWiki:Plugins.TablePlugin was that it instantly made tables more useful (sorting, row-coloring) without the need to put in front of each individual table. -- FJ

yeah, i hate it. i agree with franz for all of the reasons mentioned. this is a spec change and i feel it should be subject to more discussion. i realise this does make things more complicated, as plugins are now loaded on demand. -- WN


OK, I found an effectively undocumented control that seems to be involved in this. If you set SORT in the plugin topic it controls whether sorting happens or not. I changed the (undocumented) semantics so it:
  1. Generates sort headers for all tables if set to "all" (the default)
  2. Generates sort headers for attachment tables only if set to "attachments" (untested)
  3. Always generates sort headers for tables with %TABLE headers, even when set to "none"
Previously it wouldn't generate sort headers fo any tables if it was set to "none".

I still think this would all be much easier using Javascript.

SVN 6204

CC


Might Item331 be related to this bug? - Lynnwood

ItemTemplate
Summary TablePlugin treating TWikiTables inconsistently
ReportedBy MichaelDaum
Codebase

AppliesTo Engine
Priority Normal
CurrentState Closed
WaitingFor

Checkins 6184 6188 6189 6198 6202 6204
Edit | Attach | Watch | Print version | History: r15 < r14 < r13 < r12 < r11 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r15 - 2005-09-02 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback