A renderFormFieldForEditHandler has been added to the JSCalendarContrib
that adds a dependency on EditTablePlugin
, and is never called. It should be generalised or removed. The default date format documented for the JSCalendarContrib
is never used by DateFiledPlugin
Fixedin SVN, not released yet though.
need to look at your changes, but the renderFormFieldForEditHandler is there for a reason. It supports calling JSCalendarContrib
from Plugins. The dependency on EditTablePlugin
is a mistake, but I am surprised that I left that in. --TW
Yes, please look at my changes. I took the handler out because
- It wasn't documented anywhere
- It wasn't called anywhere
- It duplicated the implementation in DateFieldPlugin
- It added a dependency on EditTablePlugin
We can either document that the handler in the DateFieldPlugin
can be cross-called from other plugins, or we can move the handler out of the DateFieldPlugin
and into the JSCalendarContrib
is still being called from EditTablerowPlugin
so now EditTablerowPlugin is broken. And that means BlogPlugin editing is broken as well.
The handler is also documented in the topic text.
So this is still left in a mess.
Can we decide on an action?
Will handle. -- TW
Wasn't being handled, so I handled it. EditTablerowPlugin
is still SNAFU, but this is the least of it's problems.