I just noticed that the even a simple search now involves some javascript in the generated result:
<div class="patternSearchResultCount" id="twikiBottomResultCount">Number of topics: <b>67</b></div><!--/patternSearchResultCount-->
<script type="text/javascript">
// write results at the top
//<![CDATA[
insertHtml('<br />Number of topics: <b>67</b>', 'twikiNumberOfResultsContainer');
var count = 67;
if (count < 10) {
insertHtml('', 'twikiBottomResultCount');
}
//]]>
</script><p />
The use of javascript has never been discussed or agreed upon. We need to have a discussion and agreement when and where javascript is appropriate. We need to understand the impact on performance of having javascript all over our topics even where maybe not really needed.
My understanding is that the use of javascript is to be kept at a minimum.
It would be better if the number of results
at the top can be displayed by the core. But
opinions differ
.
But I am sensing there are more places you feel that javascript is not appropriate. Please provide a list so we can discuss them one at a time.
AC
Actually, I don't know whether javascript is or is not appropriate. However, we always kept javascript to a minimum, but I notice that the reliance of javascript is creeping up. We should set some standards or policies around this, I think. --
TW
No, actually we don't
rely on javascript. Our standard is
graceful degradation.
AC
This isn't a bug report, or even an enhancement description, it's a discussion item. As such it should be raised in Codev. I'm changing status to Discarded in anticipation that you will move the discussion there; we need to keep discussions like this in one place, otherwise people get confused.
CC
Well, I think it is a bug if there are things showing up in the generated topics that should not. At this point, we do not know whether the java script should appear in all the topics or not. We do not know the performance impact. But more and more java script is showing up.
Again this is not meant to be "anti-java script". I just want the use of java script to be planned and understood, and I want its performance impact to be clear.
Reopening and setting to "Wait for feedback". --
TW
See
TWiki:Codev.ExamineJavaScriptProliferation
. This item can be closed.
AC
Discarded rather than closed, as nothing needed to be changed (yet).
CC