A user is supposed to click on the registration e-mail to activate the account. This works properly most of the time, but I get at least two e-mails a week stating that "my activation code does not work on twiki.org", even though the user is already properly registered. This can happen if the user clicks twice on an activation link. It also happens if the mail software submits a URL twice on click (known bug of one mail program).
This error message is very confusing if the user already activated the account:
Invalid Activation Code
The activation code JohnSmith.6632684001 is invalid. Please try again.
The activation code should check if the user already activated the account, and show a message like this:
You already activated your account. Visit your homepage JohnSmith.
I am attaching a preliminary fix, yet I'd suggest to not commit it for 4.1: A proper fix needs I18N texts, time is too short to re-open for translations, and I would prefer to avoid a release which starts with unfinished translations. If it saves work for twiki.org, feel free to apply the patch
- What the patch does
- If a user's code is invalid but the user is already registered, it writes:
*You are already registered*
The name 'YourWikiName' has already been registered successfully.
WEBMASTER if you have any questions.
- What the patch does not do
- There is no chance to find out whether it was actually the same user who activated his account twice, or whether there has been a race condition or even an (failed) attempt to hijack a registration. I consider this harmless.
The text in the patch does not point to a user home page since user home pages might be non-existant with alternative login and/or user mapping managers.
Within the current definitions, I'm setting this item to "Actioning" though I'll not take further action beyond attaching the fix before 4.1 is out.
i checked the patch into MAIN (after various updates, as the source has moved) - thanks harald!