If you view an item with
, say, upon edit you are back to the skin that was selected.
That seems odd.
What are the rules how skins are selected?
E.g., which of these sentences should be true:
- When we move to a new screen, any currently applied skin is overridden by the skin selected for the session.
- When a user applied a skin manually in the URL parameters, that skin becomes the new skin for the continuation of the session.
Now what about
From the description in TWikiScripts
I infer that
skin once applied should stick around ("overrides the default skin path")
cover only applies to the current script ("specifies a temporary skin path")
Therefore, if I have applied
to a url I am viewing, and I am going into edit mode, the edit should also use the classic skin. This is not currently the case. -- TW
I would like to put a question mark whether I would actually want to have the suggested sticky behavour.
Adding a skin=something to the URL would for me always be something temporary. If I really want my users to see a topic in a different skin then I would set the SKIN variable as a preference setting for the topic.
I agree. I think on balance there are more cases where sticky url params would cause, rather than solve, problems. So i think sentence 1 is true.
Note that a session variable can be used to override a setting for a session. Perhaps you need to think of an easier way to set/access session variables.
I am ok with this but probably we should enhance the doco... -- TW
While stickyness may not in general be desirable, what about when going from view to edit mode? -- TW
Thomas, you left this in Waiting for Feedback state. I assume you really meant to reword it to reflect exactly what
additional doc is required, so I'm flipping this back to New for your further analysis.
No, my question was regarding to whether stickyness is desired when going from view mode to edit mode.... --TW
I can see all sorts of problems with this. You should not assume that a skin will stick through an edit. For example, the WYSIWYG editor uses the skin to invoke the relevant template (e.g. ?cover=kupu).
The skin= and cover= url parameters are really designed as temporary
overrides just for the pruposes of a single page view. My gut tells me that making them stick is not a good idea, especially when you already have a way to do that (via session variables).
OK. Stick with current non-sticky behavior, but enhance documentation of TWikiSkins
to make this clear. Also added example to explain the difference between skin and cover better and added
to the list of templates for PatternSkin
. -- TW