• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
Item2957

RcsLite has been creating topics on Unix with damaged version histories since it was first written.

The problem arose when a revision ends in a blank line; for example, say you edit a topic and delete line 123, replacing it with


Fred


Note the blank line. Then you delete the next line (old line 124, new line 125). This was stored in the revision history by the broken RcsLite as
d123 1
a123 2
Fred
d 125 1
which is clearly wrong. The problem arose because there was an unwritten assumption in RcsLite that the platform is Win32, which uses CRLF line terminations. I fixed this bug under the auspices of Item2957, but there is probably a legacy of topics that have the problem on any sites that have used RcsLite on Unix. AFAICT there is only one user affected by this.

The problem is that there is no simple way to fix topics "on the fly". I thought at first that reading the topic and saving it again would work, but it doesn't. The best approach is to write a side script that analyses affected files and fixes them under user control.

Marking as Actioning as the analysis is clear.

CC

Regrading as low as there is no evidence of anyone being affected by this.

CC

The handling of topics ending in blank lines is regularly updated, status of this Item might have changed since May.

-- TWiki:Main.SteffenPoulsen - 17 Sep 2007

ItemTemplate
Summary Rcs Lite can't recover from damaged version histories
ReportedBy TWiki:Main.CrawfordCurrie
Codebase

SVN Range TWiki-4.1, Tue, 28 Nov 2006, build 12081
AppliesTo Engine
Component

Priority Low
CurrentState Confirmed
WaitingFor

Checkins 12091
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r5 - 2007-09-17 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2023 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback