• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

I have a simple table with the following header:

%EDITTABLE{header="|*Greetings*|" format="| text, 20, Hello World |"}%

If I create the page, and immediately after that click the "Edit" button, I get the usual five buttons, and edits within the table work as expected. But "Add row" and "Delete last row" result in a Oops with an URL like the following:

http://linooox:8041/bin/oops/Sandbox/EditTableDemo?twiki_redirect_cache=/tmp/passthru_7e410567fbf98e910ef19fc095e7c85f#edittable1

The page contains the usual lease conflict information, starting with "!HaraldJoerg is editing EditTableDemo." This should not happen, because I myself have created the page. And if I click either of "Try Again" or "Edit Anyway", I end up in normal edit mode instead of table editing.

(I've tried to demonstrate the effect on EditTableDemo, but on develop viewauth seems to be missing, so you can't even get that far).

I know that there have been activities in some items regarding lease and breaking the lease, but apparently there is no ReleaseBlocker about that. However, TWiki without the ability to add a row with EditTablePlugin can't be released. I feel that the bug might be in the core, but nevertheless assign it to EditTablePlugin because I can't demonstrate it without.

If someone knows the appropriate previous item, feel free to discard this report and re-open the other one.

(Happens on TWiki 4.1rc1 and SVN)


Are you already logged in when you try to create the new row? I assume you are configured to use ApacheLogin? Does this happen with TemplateLogin? Are there any other config options we need to be aware of? Thanks.

CC


It happens with both TemplateLogin and no login manager. One of my installations is SVN, with only the required changes to the configuration (I know because I deleted LocalSite.cfg for configure tests recently), with works with LoginManager='none'. The other is a fresh (non-root) install of TWiki4.1rc1 with TemplateLogin, otherwise just default config. I am registered as HaraldJoerg.

In the SVN install, I edit as TWikiGuest, and if I hit "Add Row" I am informed that TWikiGuest is already editing.

In the 4.1rc1 install, the complete process was:

  1. Create a new topic using the Sandbox topic creator
  2. ...which asks for userid and password, I enter both (as HaraldJoerg)
  3. I add the %EDITTABLE{...}% line as above and save.
  4. I click EditTablePlugin's "Edit" button
  5. I get EditTablePlugin's edit fields and buttons
  6. I click "Add Row"
  7. I am being informed that HaraldJoerg is editing the topic
  8. Regardless of whether I click "Try Again" or "Edit Anyway" I end up in plain edit mode.

HJ


r11918 is the culprit. With all the TWiki::Func::checkTopicEditLock changes, the caller from EditTablePlugin simply has been done wrong. It missed the comparison of lock holder and login user.

HJ

Bug was introduced after 4.0.5 so no need to add to release note. Changing state to closed

KJL

ItemTemplate
Summary EditTablePlugin fails to add a new row because of a lease conflict
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-4.1, Sun, 17 Dec 2006, build 12291
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 12327
TargetRelease minor
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2006-12-30 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback