• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
When we click on the compare history link "<" on "r4 < r3 ..." we must redirect for this url:

http://safernet.org.br/twiki/bin/rdiff/SaferNet/Divulgue?rev1=4;rev2=3

But the web browser change ";" to "%3b". So... we need "&" as the url parameter separator.

We change the .../twiki-dir/lib/TWiki.pm to do this. Hire is the patch:

928c928
<                 $ps .= ';' . $p.'='.urlEncode(shift( @params )||'');
---
>                 $ps .= '&' . $p.'='.urlEncode(shift( @params )||'');
932c932
<             $ps =~ s/^;/?/;
---
>             $ps =~ s/^&/?/;

-- TWiki:Main.AurelioAHeckert

There are many other places where TWiki generates multiple parameters, so this seems to be a bigger issue. The safest fix is to prevent ";" from getting escaped as "%3b".

-- PTh


No browser should escape ";" to "%3b", and I doubt that they do. The semicolon has been chosen instead of the ampersand because usually it is the ampersand which creates a lot of escaping hassle because of its special meaning in HTML.

The Escaping occurs during redirection to the HTTPS URL, see the following telnet transcript:

$ telnet safernet.org.br 80
Trying 200.128.6.215...
Connected to safernet.org.br.
Escape character is '^]'.
HEAD http://safernet.org.br/twiki/bin/rdiff/SaferNet/Divulgue?rev1=4;rev2=3 HTTP/1.0
Host: safernet.org.br

HTTP/1.1 302 Found
Date: Tue, 26 Dec 2006 19:32:22 GMT
Server: Apache
Location: https://safernet.org.br/twiki/bin/rdiffauth/SaferNet/Divulgue?rev1=4%3brev2=3
Connection: close
Content-Type: text/html; charset=iso-8859-1

Connection closed by foreign host.

So the question to Aurelio is: How do you do the redirecting? Is this Apache based or via a TWiki feature?

HJ

It would be nice if the reporters would provide feedback.

The report was against 4.0.4. Is this a problem in 4.1.0?

I think Harald is right that the issue may be related to the redirecting.

KJL

Discarding under the 30 day rule.

CC

ItemTemplate
Summary The url parameter separator ";" is replaced by the browser and the TWiki do not recive the right parameters
ReportedBy TWiki:Main.AurelioAHeckert
Codebase 4.0.4
SVN Range TWiki-4.1, Fri, 22 Dec 2006, build 12329
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor TWiki:Main.AurelioAHeckert
Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-04-07 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback