• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

If a user edits a table using either EditTablePlugin or Edit mode, a lock is created, but subsequent edits using EditTablePlugin are not checked against the lock. It appears this was done to fix another bug: Item2684. To fix this problem I changed lib/TWiki/Plugins/EditTablePlugin/Core.pm on line 751 from...

if( ( $doCheckIfLocked ) && ( $lockUser ) ) {

...to...

if( ( $doCheckIfLocked ) && ( $lockUser ne $wikiUserName ) ) {

...and line 97 from...

$doEdit = doEnableEdit( $theWeb, $theTopic, 0 );

...to...

$doEdit = doEnableEdit( $theWeb, $theTopic, 1 );


I will take a look at the suggested fix.

If it works I will check it in. If not I set it back to new.

-- KJL

The reporter has reported the wrong version. The current SVN version does not even have these code lines anymore.

And I have tested the function and all seems to work fine. It sees the lock and warns both when you edit table and edit topic.

The code reported is not even in 4.0.5 so I wonder what version this is really a report from. Probably a beta.

Discarded. Issue has been fixed in what becomes 4.1

KJL

ItemTemplate
Summary Topic lock is ignored
ReportedBy TWiki:Main.RandyBirdsall
Codebase 4.0.5
SVN Range Tue, 04 Jul 2006 build 10807
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2006-12-29 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback