• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

There are many cases, latest one is TWiki:Plugins.PatternSkin: Kenneth updated it with the latest svn version. The topic shows r2 even though the .txt,v file has 33 revisions. Other uploads with issues in the last few days: TWiki:Plugins.TwistyContrib, TWiki:Plugins.TwistyPlugin, TWiki:Plugins.PreferencesPlugin, TWiki:Plugins.TipsContrib.

It looks like the META:TOPICINFO can be fooled by an external command. This looks like a core bug, not a BuildContrib bug.

-- PTh

Strange error.

I had not noticed the posting in TWiki:Plugins.BuildContribDev from two days earlier. Otherwise I would have uploaded the last ones manually.

As far as I can see - in the cases the revision was reverted I had first edited the plugin topic at t.o. with a normal browser changing the form contents and in some cases updated the form to the new version.

There is a reprev in the first line when you view raw data. We have to remember that t.o. runs the more buggy 4.0.2 code so the issue may be fixed. But we need to confirm this.

KJL

Duplicate of Item2680?

-- SP

See possibly related Item3458

-- PTh

From the description I suspect this is most likely to be a duplicate of Item2680 as Steffen suggests. I'm pretty sure it's unrelated to Item3458. Without a reproducable testcase it is impossible to be sure.

Plugins.BuildContrib simply uploads the topic text provided by the plugin author, using the upload script, exactly as a manual upload would be done. It knows nothing about revision numbers; it simply uploads the latest text. If the uplloaded text contains META:TOPICINFO, then that ends up confusing TWiki as described in Item2680.

The only solutions to this are to (1) fix the core so that it doesn't duplicate rev info in the topic or (2) strip the META:TOPICINFO from uploaded topics, to allow TWiki to always master it (3) discipline yourself to never add META:TOPICINFO to uploaded topics (i.e. don't edit them locally in TWiki). I had chosen to fix it using (2) but Kenneth removed my fix in check-in 12113.

I'm discarding this as a duplicate of Item2680.

CC

I removed your BUG in 12113. And re-introduced an old bug.

This hack of removing the META:TOPICINFO may be correct when you upload plugins. But it also removed the TOPICINFO from all the files in a TWiki distribution which was totally wrong.

I would suggest that we quickly fix the build script so that it removes the META:TOPICINFO from the text it uploads to twiki.org only but does not remove it from the topics in a distribution.

Ie move the stripping of the META:TOPICINFO to the code that uploads the text.

Later we will have to address the core bug because naturally anyone can still create problems by copying a debug view of a topic and paste into a new version of a topic and create similar havoc.

I reopen this bug so we can check in the build contrib fix to this one. And then Item2680 traces the core code bug which is not limited to building.

When fixed we have to remember to test both a plugin build and upload and a TWiki build, because we tend to break one when we fix the other.

KJL

And discarding again. Just realize we also have Item3216 which covers the build problem.

KJL

I am re-opening this because Item3216 handles the build.

The TOPICINFO is cached info from RCS, needed for performance (so that you do not need to call rcs for the topic info on topic view.) With this, duplicating TOPICINFO is wrong, and using the TOPICINFO of the uploaded file instead of the actual one is wrong as well. The only real fix is: ignore TOPICINFO from uploaded/edited text and refresh the TOPICINFO from RCS on topic save.

-- PTh

I discarded it because....

Item2680 covers the core bug where the core does not ignore the TOPICINFO.

Item3216 covers the build part. You can say that if 2680 is fixed 3216 is not relevant. But with the current rate of upgrading twiki.org frown the 3216 is relevant and probably not very difficult.

Peter If you agree - please either discard 2680 or this one so we only have one bug item for the same problem.

KJL

I have made a detailed analysis and a lot of tries.

And I am right. It is the core code in 4.0.2 that has a bug.

I can reproduce easily that uploading topics with META data I can alter the revision number, I can goof up the form, I can place a non-existant form making the form impossible to edit except for delRev.

And all this is fixed in 4.1. I have tried everything but 4.1 ignores any kind of META I have given it.

So upgrade Twiki.org to 4.1.0 ASAP instead of hacking the build script.

I think I know how and where to put the little piece of code I originally removed which removes the initial METATOPIC line. But it makes no sense to hack this just because twiki.org is still running with a very old buggy TWiki version.

I vote for discarding this. The best advocacy for TWiki 4.1 is to run our twiki.org on 4.1. Running on old versions all the time signals that we do not trust our own software.

KJL

Nice one that this is fixed. Thanks Kenneth for researching this.

-- PTh

ItemTemplate
Summary BuildContrib manages to create an r1 topic on twiki.org for an r33 topic
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4
SVN Range TWiki-4.1.0, Sun, 14 Jan 2007, build 12536
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2007-01-19 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback