Item3533: Redirect to viewauth broken when using script suffix and apache login

An error in a regex.

I have already fixed it.

Just opening this for the record.

-- TWiki:Main/KennethLavrsen - 30 Jan 2007

Fixed.

the following ended up being broken in this and Item3483

in ApacheLogin.pm there are 3 different types of environments depending on Apache version and short URL setups.

• $url .= '/' . $ENV{PATH_INFO} if $ENV{PATH_INFO} was added in all 3 cases but is only needed in two of them. The result was that the web and topic name was appended twice in the most normal case.
• The query string was sent to the redirect. This was originally OK. But after Thomas Weigert added the feature that maintains the query string across redirects the query string needs to be stripped off since it is added later in the redirect function
• Typo in a code line was correct in the first code fix and later replaced by a new code line.
• The redirect did not work with script suffix. A regex was too greedy so that the script name became view.pl and the auth version became view.plauth

In TWiki.pm redirect sub

• A regex was run without checking if a match was happening. The result was that an unrelated value in $1 ended up as an appended as a query string depending on what had occured earlier in ApacheLogin.

Thanks to Crawford for helping finding the latter. That was a tough one.

Fix has been merged into Patch04x01

-- TWiki:Main.KennethLavrsen - 30 Jan 2007

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008