• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Configure needs some polishing

  1. It would be good if we could have a logo
  2. Need to improve the logic when localsite.cfg is missing

CC


Did the logic bit SVN 6301 CC
favicon added SVN:6300 WN (see Item355)


the icon is covered by Item341


i don't see any icons (either on the page, or a favicon); am i missing something? WN

aha, configure might need an extension (eg, .cgi, .pl, etc.) ok, i'm working on a patch WN

Index: configure
===================================================================
--- configure   (revision 6698)
+++ configure   (working copy)
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/local/bin/perl -w
 #
 # TWiki Collaboration Platform, http://TWiki.org/
 #
@@ -2299,8 +2299,8 @@
         CGI::meta({ 'http-equiv'=>'Cache-Control', content=>'no-cache' }),
         CGI::meta({ 'http-equiv'=>'Expires', content=>0 }),
         CGI::meta({ name=>'robots', content=>'noindex' }),
-        CGI::Link( { -rel=>'icon', -href=>'configure?action=image;image=configure.ico;type=image/x-icon', -type=>'image/x-icon' } ),
-        CGI::Link( { -rel=>'shortcut icon', -href=>'configure?action=image;image=logos/configure.ico;type=image/x-icon', -type=>'image/x-icon' } ),
+        CGI::Link( { -rel=>'icon', -href=>$ENV{SCRIPT_NAME}.'?action=image;image=configure.ico;type=image/x-icon', -type=>'image/x-icon' } ),
+        CGI::Link( { -rel=>'shortcut icon', -href=>$ENV{SCRIPT_NAME}.'?action=image;image=logos/configure.ico;type=image/x-icon', -type=>'image/x-icon' } ),
         CGI::script( { language => 'JavaScript',
                        type => 'text/javascript' }, $js1 ),
         CGI::style( { -type=>'text/css' }, $css),
@@ -2313,7 +2313,7 @@
 print CGI::header('text/html'), $hdr;

 my $body = "";
-$body .= CGI::h1( CGI::img({src=>'configure?action=image&image=logo.png;type=image/png', alt=>'TWiki'}).
+$body .= CGI::h1( CGI::img({src=>$ENV{SCRIPT_NAME}.'?action=image;image=logo.png;type=image/png', alt=>'TWiki'}).
   ' Configuration');

 my $update_disabled = 0;

SVN:6700

WN

ItemTemplate
Summary Polish up configure - waiting for icon
ReportedBy CrawfordCurrie
Codebase

AppliesTo Engine
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 6301 6699 6700 6701
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2005-09-30 - WillNorris
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback