• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3665: RCS units tests makes an awful noise and influence following tests to be noisy also

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 4.1.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

As I am trying to make perl work in perl 5.6.1 including making unit tests pass I am getting sick and tired of seeing my screen flooded with illegal seek statements and yet see that the test is declared as passed.

I noticed that some test cases did not make noise when run alone but the minute I run the TWikiSuite the noise begins.

I found out it is because of a few settings in RCSTests.pm

To make RCSTests pass with no noise I comment out this one statement

    #$twiki->{sandbox}->{REAL_SAFE_PIPE_OPEN} = 0;

And so enable people to enable this line for debugging but still not destroy the next test cases this works

sub tear_down {
    my $this = shift;
    # Next two are added as they influence next test cases run
    # in the TWikiSuite
    $twiki->{sandbox}->{REAL_SAFE_PIPE_OPEN} = 1;
    $twiki->{sandbox}->{EMULATED_SAFE_PIPE_OPEN} = 1;
    File::Path::rmtree("$TWiki::cfg{DataDir}/$testWeb");
    File::Path::rmtree("$TWiki::cfg{PubDir}/$testWeb");
    eval {$twiki->finish()};
    $this->SUPER::tear_down();
}

adding the two lines for setting the SAFE_PIPEs to 1

I am not sure if this is the right way to do it but it works and now I can run all unit tests with very little noise.

So I check in the changes.

-- TWiki:Main/KennethLavrsen - 20 Feb 2007

Closed - no need for entry in release notes

-- TWiki:Main/KennethLavrsen - 20 Feb 2007

Per advice from Crawford I commented out both SAFE_PIPE settings. The original idea of those was extra debug feedback.

And then removed again the tear_down modification earlier checked in in 12944 12945 since this could prevent unit tests from running under Windows.

-- TWiki:Main/KennethLavrsen - 21 Feb 2007

ItemTemplate
Summary RCS units tests makes an awful noise and influence following tests to be noisy also
ReportedBy TWiki:Main.KennethLavrsen
Codebase ~twiki4
SVN Range TWiki-4.1.1, Tue, 20 Feb 2007, build 12932
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 12944 12945 12954 12955
TargetRelease patch
ReleasedIn 4.1.2
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-02-21 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback