• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3672: Unit test case for CommentPlugin broken

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine CommentPlugin Normal Closed   n/a 4.1.2

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Unit test case for CommentPlugin broken

1) CommentPluginTests.pm:138 - test_below(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="below1"'

2) CommentPluginTests.pm:138 - test_targetWebTopicAnchorBottom(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="bottom1"'

3) CommentPluginTests.pm:138 - test_LocationRE(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="above1"'

4) CommentPluginTests.pm:138 - test_above(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="above1"'

5) CommentPluginTests.pm:138 - test_targetWebTopic(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="bottom1"'

6) CommentPluginTests.pm:138 - test_location(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="below1"'

7) CommentPluginTests.pm:138 - test_targetWebTopicAnchorTop(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="top1"'

8) CommentPluginTests.pm:138 - test_targetTopic(CommentPluginTests)
expected 'enctype="multipart/form-data"', got 'enctype="application/x-www-form-urlencoded" id="bottom1"'

A quick analysis shows that the enctype is supposed to be per default application/x-www-form-urlencoded in CGI::Startform()

And the id= was added recently.

The change in the CommentPlugin that probably changed the bahavour is SVN 12244 Item3300: Resolve uninitialized values

And at that time the test case was not touched.

I have the fix ready. And it also passes in Perl 5.6.1

Unit tests are not part of release of a plugin so no need to upload a new version or to include this in release note for 4.1.2

-- TWiki:Main/KennethLavrsen - 21 Feb 2007

ItemTemplate
Summary Unit test case for CommentPlugin broken
ReportedBy TWiki:Main.KennethLavrsen
Codebase ~twiki4
SVN Range TWiki-4.1.1, Tue, 20 Feb 2007, build 12932
AppliesTo Engine
Component CommentPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 12956 12957
TargetRelease n/a
ReleasedIn 4.1.2
Topic revision: r1 - 2007-02-21 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback