• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3751: {Site}{Charset} semantics are inconsistent

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configuration, I18N Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

In Cairo, {Site}{Charset} was mostly derived from {Site}{Locale} - this meant only the latter needed to be set in most cases. The only reason for a separate setting was that sometimes the server locale's spelling of charset differs from what browsers will accept in the HTTP headers (e.g. utf8 vs utf-8), so this could be overriden as an exception. This is one of the issues complained about re I18N setup being complex, in Item3715.

Somewhere in the 4.0 refactoring, the code that derives Charset was moved into a checker module under configure, which I just noticed.

The text within the Configure UI is not consistent - at the top of the Localisation it says 'just set Charset to turn on UserInterfaceInterntionalisation', whereas on the Charset setting it says 'use as override only'. The latter is also what I said in the I18N setup docs, based on the pre-4.0 docs, since I didn't think to check whether refactoring had changed the semantics.

To get charset I18N working now, you have to enter a full locale as well as the charset, which is harder to get right (just tripped me up doing 4.1.2 installation).

I suggest we revert the semantics to the original state - this makes it simpler to configure I18N generally (as logged in Item3715), and if the user has explicitly set {Charset} they will still be able to use this.

Also, we need to revert {Site}{Lang} and {Site}{FullLang} to being calculated, which will also simplify things.

Any objections?

-- TWiki:Main/RichardDonkin - 12 Mar 2007

Sounds fair to me. Anything that simplifies this very complex area is a good thing. As long as it works.

-- TWiki:Main.KennethLavrsen - 12 Mar 2007

There will be a minor upgrade issue for people who have not set a locale but have set a charset, but this is an incorrect config anyway and could be detected with a Checker in configure perhaps.

-- TWiki:Main.RichardDonkin - 12 Mar 2007

Update above - the I18N code I thought was removed has mostly been migrated to checkers under configure, but some has been removed (the URL encoding stuff, now about to re-instate).

-- RichardDonkin - 24 Mar 2007

Richard fixed this some time ago (thanks!), closing. I think it is enough to have Item3715 in the release notes.

-- TWiki:Main.SteffenPoulsen - 17 Sep 2007

ItemTemplate
Summary {Site}{Charset} semantics are inconsistent
ReportedBy TWiki:Main.RichardDonkin
Codebase 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, 4.1.0, 4.1.1, 4.1.2
SVN Range TWiki-4.1.2, Sat, 03 Mar 2007, build 13043
AppliesTo Engine
Component Configuration, I18N
Priority Normal
CurrentState Closed
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-09-17 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback