Item3775: Commentplugin makes inappropriate line ending handling when targeting an anchor

TWiki:Sandbox/HughTest666

This is probably caused by the incompatible spec change of not removing leading and traling spaces in the templates. There are probably other comment plugin templates besides type="tableprepend" that are broken as well.

-- TWiki:Main/PeterThoeny - 16 Mar 2007

I just tried it on the latest plugin, and it works perfectly. I guess it was fixed since this report.

CC

As of today, it looks very much broken to me in the MAIN branch: TestItem3775. Please do not discard real bugs.

-- PTh

As I stated, I tested on MAIN and it does not occur. You did not test on MAIN, you tested on this site which has not been updated for some time.

CC

I just tested it out on my local svn checkout. Same bug. See attachment.

Also, the signature is non-standard, it would be helpful to add the dash-dash to the signature.

-- PTh

This bug is most likey caused by the spec change of no longer removing leading and trailing newlines in template fragments. Spec changes always bite back.

-- PTh

Highly unlikely, since that particular change was shipped some considerable time ago. Further, I have now tested tableprepend on three separate MAIN installs, one of which is completely fresh checkout from subversion (no config except the absolute minimum in configure). In all cases tableprepend works as documented. I'm guessing that you have local template definitions that are overriding the defaults. One remote possibility; are you testing on a Windows server? Possibly there is a CRLF issue?

BTW the signature in the table is not a signature in the usual sense; it is a wiki user name in a table cell. Using -- in a table cell would not be appropriate IMHO.

-- CrawfordCurrie - 31 May 2007

I just checked again. I renamed TWiki.UserCommentTemplate, and there is no user template in the Sandbox web. Same issue.

-- PTh

Wierd. I just tested MAIN on a Windows+IndigoPerl server and it works fine there too, so it's nothing to do with CRLF :-/

What server platform are you using? Can you share the exact topic you are trying to comment into (however simple it may be)?

CC

I have an exact copy of TestItem3775.

Linux server_name 2.4.21-27.ELsmp #1 SMP Wed Dec 1 21:59:02 EST 2004 i686 i686 i386 GNU/Linux

perl, v5.8.0 built for i386-linux-thread-multi

-- PTh

OK, that clears it up. It's nothing to do with the tableprepend template, it's because you used a target. So I have been trying to reproduce the wrong thing.

Fixed. Marking it "Waiting for Release" as it's a core plugin.

-- TWiki:Main.CrawfordCurrie - 03 Jun 2007

Updated headline for release note so it better describes the problem that has been fixed.

-- TWiki:Main.KennethLavrsen - 03 Jun 2007

Thank you for fixing this bug. And please do not discard bugs that quickly.

-- TWiki:Main.PeterThoeny - 04 Jun 2007