• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3784: Rename across webs bugs

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I moved TWiki:Codev/MediaWikiConversion to TWiki:Plugins/MediaWikiToTWikiAddOnDev. Besides taking more than 5 minutes and resulting in an "internal server" HTML formatted error delivered in plain text to the browser, there are several issues with rename across webs:

1. The Codev web has a topic called ML. References to HTML have been converted to HTCodev.ML and, references to XML to XCodev.ML.

2. Escaped words are prefixed with "Codev". For example, !MediaWiki turns into !Codev.MediaWiki.

3. URLs containing a WikiWord of an existing topic in the Codev web get destroyed. For example, [[http://trac.edgewall.org/wiki/TracWiki][the Trac Wiki engine]] turns into [[http://trac.edgewall.org/wiki/Codev.TracWiki][the Trac Wiki engine]].

(I fixed the topic manually.)

-- TWiki:Main/PeterThoeny - 18 Mar 2007

Possibly related to Item3760.

-- TWiki:Main.ArthurClemens - 18 Mar 2007

I believe the problem exists in Render.pm, in sub replaceTopicReferences. It looks like the second to last search/replace is too aggressive.

$text =~ s/(\W|^)$args->{oldTopic}\b/$1$repl/g;
makes more sense to me.

-- TWiki:Main.CrawfordCurrie - 20 Mar 2007

Worth making sure the regex is I18N-safe - \w is always a bad idea because platforms such as Windows have broken Perl locales... See TWiki:Codev.InternationalisationGuidelines.

I originally spent some time making renames work for I18N, but didn't manage to fix the other bugs like this.

-- TWiki:Main.RichardDonkin - 20 Mar 2007

\W not \w. Really \b ought to work, but it was removed in the past for some reason, so I assume it was tried but had other problem.

-- TWiki:Main.CrawfordCurrie - 21 Mar 2007

Fixed on MAIN but not merged to patch branch.

Could also do with some user testing.

CC

ItemTemplate
Summary Rename across webs bugs
ReportedBy TWiki:Main.PeterThoeny
Codebase 4.1.2
SVN Range TWiki-4.1.2, Sat, 17 Mar 2007, build 13167
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:13367
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback