Item3803: %!USERINFO{format="$groups"}% crashes

TWiki:Main/SvenDowideit

[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] Can't call method "webDotWikiName" on unblessed reference at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 3662.
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1]  at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 3662
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::_USERINFO('TWiki=HASH(0x814f6c0)', 'TWiki::Attrs=HASH(0x8bf6488)', 'SvenDowideit', 'Main') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 2461
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::_expandTagOnTopicRendering('TWiki=HASH(0x814f6c0)', 'USERINFO', 'format=" $emails, $username, $wikiname, $wikiusername, $group...', 'SvenDowideit', 'Main') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 2380
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::_processTags('TWiki=HASH(0x814f6c0)', '\\x{a}\\x{a}\\x{a}   * %USERINFO%\\x{a}   * %USERINFO{format=" $emails, $username...', 'CODE(0x8845f74)', 16, 'SvenDowideit', 'Main') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 2306
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::_expandAllTags('TWiki=HASH(0x814f6c0)', 'SCALAR(0x8b4d2d0)', 'SvenDowideit', 'Main') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki.pm line 2659
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::handleCommonTags('TWiki=HASH(0x814f6c0)', '\\x{a}\\x{a}\\x{a}   * %USERINFO%\\x{a}   * %USERINFO{format=" $emails, $username...', 'Main', 'SvenDowideit', 'TWiki::Meta=HASH(0x8b307e0)') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki/UI/View.pm line 375
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::UI::View::_prepare('\\x{a}\\x{a}\\x{a}   * %USERINFO%\\x{a}   * %USERINFO{format=" $emails, $username...', 'TWiki=HASH(0x814f6c0)', 'Main', 'SvenDowideit', 'TWiki::Meta=HASH(0x8b307e0)', 0) called at /usr/lib/cgi-bin/TWiki4/lib/TWiki/UI/View.pm line 359
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::UI::View::view('TWiki=HASH(0x814f6c0)') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki/UI.pm line 160
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::UI::__ANON__() called at /usr/lib/cgi-bin/TWiki4/lib/CPAN/lib//Error.pm line 379
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \teval {...} called at /usr/lib/cgi-bin/TWiki4/lib/CPAN/lib//Error.pm line 371
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tError::subs::try('CODE(0x814f5a0)', 'HASH(0x8b4cb74)') called at /usr/lib/cgi-bin/TWiki4/lib/TWiki/UI.pm line 200
[Fri Mar 23 23:35:06 2007] [error] [client 127.0.0.1] \tTWiki::UI::run('CODE(0x819cb88)', 'view', 1) called

The fix in TWiki::_USERINFO() is:

-        my @groupNames = map {$_->webDotWikiName();} $user->getGroups();
+        my @groupNames = map {$_->webDotWikiName();} @{$user->getGroups()};

Questions is, however, why the return value of TWiki::User::getGroups() has changed. This worked before. Does getGroups() need a fix? Crawford, you changed the code in that area recently.

TWiki:Main.MichaelDaum - 24 Mar 2007

However I think a better fix is to complete the refactoring that I started with my recent mail to you (eliminating the user objects).

CC

Refactored in Item3838

CC