• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

In ContributorsPlugin.pm, this patch is needed:

The plugin crashes any page using it without it, and near as I can tell, this patch restores basic function. The "crash" indicates a "requirement" priority, so I humbly submit it as such.

The rest of this plugin should probably be examined by someone familiar with the API changes since this plugin was first written. I didn't test any combinations besides the ones my site was using.

--- lib/TWiki/Plugins/ContributorsPlugin.pm.orig        2005-09-14 01:21:40.000000000 -0700
+++ lib/TWiki/Plugins/ContributorsPlugin.pm     2005-09-14 12:36:42.000000000 -0700
@@ -129,12 +129,12 @@
             @lines = $meta->getRevisionInfo();
             $lines[1] = $lines[1]->wikiName();
         } else {
-            @lines = TWiki::Store::getRevisionInfo($web, $topic, $revision);
+            @lines = TWiki::Func::getRevisionInfo($web, $topic, $revision);
         }

         for ($lineIndex = 0; $lineIndex < $#lines; $lineIndex += 4) {
            my $date = &TWiki::Func::formatTime($lines[$lineIndex+0], "http");
-           my $author = $lines[$lineIndex+1];
+           my $author = $lines[$lineIndex+1]->wikiName;
            my $revisionNumber = $lines[$lineIndex+2];
            my $comment = $lines[$lineIndex+3];
            $contributorLine = &formatContributorLine($web, $topic, $author, $date, $revision, $format);

Apologies if plugin bugs for Dakar should go elsewhere.


Thanks Jared. Your use of wikiname() highlighted a problem in the API - it needs to return the wikiname of the user, not the user object, for compatibility with Cairo.

This is the right place for bug reports.

All fixed in SVN 6403 CC

ItemTemplate
Summary ContributorsPlugin needs API update
ReportedBy JaredRhine
Codebase

AppliesTo Extension
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 6403
Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2005-09-17 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback