• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3862: Parameter passed to preRenderingHandler incorrect

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The documentation says that the second parameter to preRenderingHandler is a reference to a hash that maps the placeholders to the removed blocks. And later it states that
Placeholders are text strings constructed using the tag name and a 
sequence number e.g. 'pre1', "verbatim6", "head1" etc. Placeholders are 
inserted into the text inside <!--!marker!--> characters so the 
text will contain <!--!pre1!--> for placeholder pre1.

A subsequent example uses verbatim, so clearly the user should assume that this parameter holds placeholders for verbatim, etc.

However, it turns out that such is not the case. The parameter only holds the map for pre.

The consequence of this is that it is *impossible to restore verbatim text that is manipulated in a plugin, once the endRenderingHandler (deprecated) is removed.

Further, the code is inconsistent with the documentation.

My suspicion is that some overzelous optimization was used to split the placeholders into separate maps, but forgot to pass all these maps into the preRenderingHandler.

-- TWiki:Main/ThomasWeigert - 09 Apr 2007

Yes, your analysis is right on the money. Confirmed.

CC

ItemTemplate
Summary Parameter passed to preRenderingHandler incorrect
ReportedBy TWiki:Main.ThomasWeigert
Codebase 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, 4.1.0, 4.1.1, 4.1.2
SVN Range TWiki-4.1.2, Sat, 07 Apr 2007, build 13305
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:13389 TWikirev:13390 TWikirev:13391 TWikirev:13392 TWikirev:13396
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback