• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3883: No rendering of TML after %BR% used in table cells and multiline bullets

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

A co-worker asked me how to doo itallics insiide a TWiki table cell. We're using standard TWiki table format in an Editable Table with EDITTABLE.

Her cell contained

<b>Prerequisites</b>: _Igorization_, 
_ProdOps Request Fulfillment_

The first italicized word worked. The second italicized phrase did not.

Thaty is, single words were italicized; multiple words with spaces were not.

-- TWiki:Main/VickiBrown - 12 Apr 2007

  • screenshot:
    Item3883_screenshot.jpg

Here's a table containing Vicki's cell, with an appropriate %EDITTABLE:

Prerequisites: Igorization, ProdOps Request Fulfillment
So, AFAICT it works fine in the current code. Further, editing the table shows up no other issues.

Bouncing back to the reporter for clarification of what the problem is, and a testcase.

CC

Probably this will show up as equest Fulfillment_| when viewed in raw mode. To make the TML italics work a space in front of the | is needed. Maybe some versions of the plugin doesn't automatically insert this?

Vicki, please paste a bit more of the topic (i.e. the whole table) as seen in raw mode.

-- TWiki:Main.SteffenPoulsen - 13 Apr 2007

Vicki, any update? If we don't hear from you before 12 May we will discard this....

-- TWiki:Main.CrawfordCurrie - 02 May 2007

Vicki obviously never came back to see of the bug was followed up on.

But the bug is real. I just guess we did not originally notice that the report had a newline in the cell content.

Look at this

Prerequisites: Igorization,
ProdOps Request Fulfillment
http://www.lavrsen.dk
http://twiki.org
http://www.lavrsen.dk
http://www.lavrsen.dk

This is the table you get when you enter multiple lines in EditTablePlugin. The plugin adds the %BR% between each line.

The %BR% prevents the renderer from seeing the text that follows as TML. Also URLs fail to render. I fight with the latter all the time. The work around is to add a space before the following lines when you enter them in the Edit mode. But a nice work around and we should find a fix for this.

This is not an EditTablePlugin problem only. Even with simple bullet points we have same problem.

So it is the use of
we should attack instead of hacking the plugin.

The quick and dirty fix is to change the definition of %BR% to contain a trailing space.

It seems to fix things and after having tested around on my test server for half an hour I have not yet seen any negative effect of this.

HTML does not care about trailing spaces and the space is added between the <br /> and the \n where it does no harm. But for the Twiki renderer there is a space between the <br /> and whatever follows. I cannot imagine anyone counting on a %BR% preventing linking. On the contrary it has probably been an irritation having to add a space. And for anyone already adding a space this is also safe in HTML since multiple whitespace is turned into a single space.

I will try and do the change on my code base and run the unit tests now.

Scream if anyone sees a problem.

If I end up adding this I will put a comment in TWikiPreferences before the setting that there is an intentional trailing space.

-- KennethLavrsen - 27 May 2007

Unit test cases seems to pass with the same failure as without this change. It is difficult to be sure because currently running the test cases produce kilobytes of other errors. So I cannot guarantee that there has not sneaked in an additional failure. But the number is unchanged and their nature seems to be not at all related to this. Pain that we have to suffer so many failing unit test cases. frown It cost so much extra time for us that do care to check before we check in.

-- KennethLavrsen - 27 May 2007

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary No rendering of TML after %BR% used in table cells and multiline bullets
ReportedBy TWiki:Main.VickiBrown
Codebase 4.0.5, 4.1.2, ~twiki4
SVN Range TWiki-4.1.2, Sat, 07 Apr 2007, build 13305
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:13928
TargetRelease minor
ReleasedIn 4.2.0
Topic attachments
I Attachment History Action Size Date Who Comment
JPEGjpg Item3883_screenshot.jpg r1 manage 8.0 K 2007-04-12 - 22:53 VickiBrown screenshot
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback