• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3907: AttachContentPlugin setting COMMENT clashes with CommentPlugin

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension AttachContentPlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

AttachContentPlugin setting COMMENT clashes with CommentPlugin

The COMMENT setting is just newly added. But the name is not well chosen because having a Set COMMENT = Something means that you cannot use %COMMENT any more.

It needs to be renamed ASAP before too many download the new version.

I propose ATTACHCONTENTCOMMENT as setting name.

-- TWiki:Main/KennethLavrsen - 15 Apr 2007

There are more problems.

Having settings for this plugin in the topic itself it a problem. Because the action happens during save the settings that you update while you edit are not used but instead the previous set is used. Very confusing. The best is to use the new nice options within the tag. So instead I will change the plugins settings to only work as plugin setting and add the missing parameter for keeping certain tags intact.

KJL

Done

Only the ATTACH tages are hidden and not the text between them

Added parameter keeppars with same function as KEEPVARS plugin setting

Removed the possibility to use plugin settings in topic unprefixed as this signaled that this was working. But since these topic settings are not read from the saved topic but previous topic it became quite confusing. It is better to have the settings in the STARTATTACH parameters. We should consider removing all the plugin settings for performance.

-- TWiki:Main.KennethLavrsen - 16 Apr 2007

ItemTemplate
Summary AttachContentPlugin setting COMMENT clashes with CommentPlugin
ReportedBy TWiki:Main.KennethLavrsen
Codebase

SVN Range TWiki-4.1.2, Sat, 14 Apr 2007, build 13397
AppliesTo Extension
Component AttachContentPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:13437
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2007-04-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback