Item4014 < Bugs

• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use

Item7848 for generic doc work for TWiki-6.1.1. Use

Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Extension	MailerContrib	Normal	Closed		n/a

Hi Crawford, I noticed a small bug when the mailnotify script is called when no changes have occurred on a web. The last notification time was being reset back to 0, and then the next round in the cron would resend all the same notifications again. Here is a patch to fix the problem:

--- Mailer.pm   2007-04-24 10:13:59.000000000 -0700
+++ Mailer.pm   2007-05-03 15:01:28.000000000 -0700
@@ -204,9 +204,12 @@

     $report .= _sendNewsletterMails( $twiki, $web, \%allSet);

-    if( open(F, ">$notmeta" )) {
-        print F $timeOfLastChange;
-        close(F);
+    if($timeOfLastChange != 0)
+    {
+        if( open(F, ">$notmeta" )) {
+            print F $timeOfLastChange;
+            close(F);
+        }
     }

     return $report;

-- TWiki:Main.JeffCrawford - 03 May 2007

Jeff's patch was right on the money

ItemTemplate
Summary	Notify time being reset when there are no changes
ReportedBy	TWiki:Main.JeffCrawford
Codebase
SVN Range	TWiki-4.1.2, Thu, 03 May 2007, build 13616
AppliesTo	Extension
Component	MailerContrib
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	TWikirev:13623
TargetRelease	n/a
ReleasedIn

Item4014: Notify time being reset when there are no changes

Item Form Data

Edit Form Data

Detail