• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4028: Authenticated twice; garbled CommentPlugin text

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I tried to add a comment to Item3889. My PC was not authentiated. To reproduce:
  • Restart browser
  • Add a comment to an existing topic via comment box
  • You will be asked twice to login (here in Bugs web)
  • Content of comment box is added as garbeled text. (See Item3889)
-- TWiki:Main/PeterThoeny - 07 May 2007

Test:

  • %CALC{$EXISTS(%TOPIC%)}% returns 1
  • %CALC{$EXISTS(%TOPIC%Xyz)}% returns 0

-- TWiki:Main.PeterThoeny - 07 May 2007

Adding above text via comment box works properly if already authenticated.

Not sure if this is a core bug or CommentPlugin bug. I suspect a core bug.

-- TWiki:Main.PeterThoeny - 07 May 2007

I can't reproduce this, either here or in Item3889; Is it possible that you tried to add the comment when d.t.o was in the middle of an svn up? Can you reproduce the problem on a stable install?

Note: the double authentication was added (I think) to allow testing of template login as well as apache login. I don't think it should have any effect on this, but it's possible.

-- CrawfordCurrie - 08 May 2007

Just had another case. Exactly the same case as described above. See Item3599. I am on Win XP using FF 1.5.0.11.

-- TWiki:Main.PeterThoeny - 12 May 2007

I went back in my browser but found only one login screen:

image1.png

Notice the "Error:" and "please contact 0".

Screen looked normal, e.g. it did not appear to be in the middle of an svn update (although it would be possible that this was the case.)

-- TWiki:Main.PeterThoeny - 12 May 2007

I'm really puzzled by this; I think it has to be to do with passthrough over the double login, but I can't reproduce it. if you can nail down the conditions under which it happens it would be most helpful. I assume it doesn't happen twice in a row? i.e. if you shut down the browser and repeat the same steps?

-- TWiki:Main.CrawfordCurrie - 13 May 2007

%22Removing%20InterwikiPlugin%2c%20SmiliesPlugin%20and%20TablePlugin%20from%20the%20list.%20The%20former%20two%20have%20a%20special%20syntax%2c%20e.g.%20you%20can

-- TWiki:Main.PeterThoeny - 13 May 2007

I just reproduced it again by restarting the browser and adding above text (copied from Item3599.)

-- TWiki:Main.PeterThoeny - 13 May 2007

This is the first auth:

image5.png

That seems to be basic auth login. This is followed by a template login (previous screenshot)

-- TWiki:Main.PeterThoeny - 13 May 2007

I have not seen garbled text but it happens all the time that I am asked to authenticate twice here on d.t.o.

When I add a comment I am first asked to authenticate by the browser and then asked to authenticate with Template Login.

Someone recently changed d.t.o back from Apache Login to Template Login. Did that someone remember to remove the require valid-user for the bin scripts in the Apache config?

-- TWiki:Main.KennethLavrsen - 15 May 2007

I thought they had left it there for a reason, which is why I didn't remove it....

-- TWiki:Main.CrawfordCurrie - 15 May 2007

OK, I narrowed it down; it happens with just plain template login, nothing to do with Apache.

I turned off apache here.

CC

Testing if the bug is still there by submitting this comment

I could add this without being authenticated twice. Did you change the setting on d.t.o. CC. Did you restart Apache after having changed it?

-- TWiki:Main.KennethLavrsen - 15 May 2007

Yes, and no.

The problem is nothing to do with double authentication; it is to do with the way the parameters are encoded in the login page. It will take some deeper research to nail down.

CC

This must be fixed before the next release; raising priority to urgent.

CC

Fixed in 14536, accidentally attributed to Item3599

CC

ItemTemplate
Summary Authenticated twice; garbled CommentPlugin text
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4
SVN Range TWiki-4.1.2, Thu, 03 May 2007, build 13616
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 14536
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback