• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4051: Failing registration tests are wrong

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

19:20:22) CDot: SvenDowideit: do we need those two tests? ShortPsswrod and NoPassword?
(19:20:43) SvenDowideit: CDot, i presume they were written to test some func
(19:20:56) CDot: SvenDowideit: yes, but that func is htpasswd
(19:21:47) CDot: the text reads "# This test is supposed to ensure that the system can reset passwords
(19:21:47) CDot: # for a user currently absent from .htpasswd"
(19:22:03) CDot: my question is, why would you want to do that?
(19:22:11) CDot: at the moment, it whinges
(19:22:23) CDot: the test is to make sure it doesn;t whinge, which sounds wrong
(19:22:44) SvenDowideit: dunno - i was looking at the password length one
(19:23:12) SvenDowideit: and it seemed to me reasonable that if you set twiki to have min length of 4 then it should refuse to let you have oe less than 4
(19:23:24) CDot: SvenDowideit: right
(19:23:31) SvenDowideit: and that one's failing
(19:23:36) CDot: so in both cases, the tests are testing the wrong thing
(19:23:41) SvenDowideit: huh?
(19:24:05) CDot: both tests fail because they are wrong, they are asserting something bad
(19:24:15) CDot: the tests need to be fixed, not the code
(19:24:15) SvenDowideit: ok, i give in, i dn't feel i can read the mind of the test's writer
(19:24:23) CDot: no, me neither
(19:24:23) SvenDowideit: i can only assume they wrote them for a good reason
(19:24:39) CDot: usually martin's tests make reasonable sense
(19:24:44) CDot: but this time....
(19:25:01) SvenDowideit: maybe he was testing how it was working
(19:25:08) SvenDowideit: to make sure it continued working that way
(19:26:09) CDot: well... maybe, but I think the fundamental supposition was based on TWiki having full control over users
(19:26:19) CDot: which is no longer the case
(19:26:30) SvenDowideit: mmm, actually, it is
(19:26:43) SvenDowideit: those tests are all for the TWikiUserMapping case
(19:26:56) SvenDowideit: and there, i fervenlty hope there is no change in func
19:27:34) CDot: they are both for resetting passwords; why should an invisible user be able to reset their password? doesn;t make sense
(19:27:58) CDot: and, as you say, the shortness constraint should apply always#
((19:29:14) SvenDowideit: CDot, your logic sounds inviting :)
-- TWiki:Main/CrawfordCurrie - 11 May 2007

ItemTemplate
Summary Failing registration tests are wrong
ReportedBy TWiki:Main.CrawfordCurrie
Codebase

SVN Range TWiki-4.1.2, Fri, 11 May 2007, build 13693
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:13694
TargetRelease n/a
ReleasedIn

Topic revision: r1 - 2007-05-11 - TWikiUserMapping_CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback