Item4113: Bugs in installing extensions through configure (UI.pm and EXTEND.pm)

I've run into a couple of bugs that prevent the installation of Extensions via the configure interface, that have been reported by others too (cf. TWiki:Support.PluginsInstallWithConfigureDontWork).

I dug a little further into these and am recording the necessary fixes here.

Connection to twiki.org fails

Add a User-agent field at Configure/UI.pm:263:

261:    my $req = "GET $path HTTP/1.0\r\nHost: $host\r\nUser-agent: TWikiConfigure/1.0 +http://twiki.org/\r\n\r\n";
262:    if ($TWiki::cfg{PROXY}{HOST} && $TWiki::cfg{PROXY}{PORT}) {
263:        $req = "GET http://$host:$port$path HTTP/1.0\r\nUser-agent: TWikiConfigure/1.0 +http://twiki.org/\r\n\r\n";
264:        $host = $TWiki::cfg{PROXY}{HOST};
265:        $port = $TWiki::cfg{PROXY}{PORT};
266:    }

I believe our proxy server was rejecting the query if the User-agent is not defined. Since this is defined in line 261 and not in line 263, I just copy/pasted the string.

OK

Duplicate of Item4124

Untar fails

Changes in Configure/UIs/EXTEND.pm:

63c63
<     } elsif ($ar !~ s!^.*Content-Type: application/x-gzip\r\n\r\n!!is) {
---
>     } elsif ($ar !~ s!^.*Content-Type: application/x-gzip.*\r\n\r\n!!is) {
88c88
<       } elsif ($ar !~ s#^.*Content-Type: application/zip\r\n\r\n##is) {
---
>       } elsif ($ar !~ s#^.*Content-Type: application/zip.*\r\n\r\n##is) {  

This was not removing the entire HTTP header, since the Content-Type field was not at the end (at least in my case). The trailing .* did the trick.

Duplicate of Item3885

File::Copy::move() cannot move directories across file systems

The move at Configure/UIs/EXTEND.pm:345 fails with the message:

Error: Failed to move file 'pub/TWiki/NatSkin' to /nfs/site/disks/wiki_base_1/test/TWiki-4.1.2/pub/TWiki/NatSkin: Is a directory

The code needs to be rewritten using File::Copy::Recursive or File::NCopy (the latter is not installed on our system).

Works smoothly if I go to the Unix side and do mkdir pub/TWiki/NatSkin. Although, configure doesn't seem to bother about dependencies :-(, I had to take care of each one separately (and TWiki:Plugins.NatSkin has a bunch).

Duplicate of Item3748

-- TWiki:Main/PankajPant - 22 May 2007

OK, I added the User-agent as you suggest.

Just a note for the future; can you please check for duplicates, otherwise I end up spending ages looking at problems that are already fixed; and can you please report bags in individual bug topics. It's impossible to track them when they are all crammed into one report.

CC

Shucks. It would have saved me a whole day of grief if I had seen those two before :-(.

I'll make sure I check up existing bugs in future ... this was my first.

-- TWiki:Main.PankajPant - 23 May 2007

Closing this since there are individual bug items for all 3 above.

KJL