• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4113: Bugs in installing extensions through configure (UI.pm and EXTEND.pm)

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configure Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I've run into a couple of bugs that prevent the installation of Extensions via the configure interface, that have been reported by others too (cf. TWiki:Support.PluginsInstallWithConfigureDontWork).

I dug a little further into these and am recording the necessary fixes here.

Connection to twiki.org fails

Add a User-agent field at Configure/UI.pm:263:
261:    my $req = "GET $path HTTP/1.0\r\nHost: $host\r\nUser-agent: TWikiConfigure/1.0 +http://twiki.org/\r\n\r\n";
262:    if ($TWiki::cfg{PROXY}{HOST} && $TWiki::cfg{PROXY}{PORT}) {
263:        $req = "GET http://$host:$port$path HTTP/1.0\r\nUser-agent: TWikiConfigure/1.0 +http://twiki.org/\r\n\r\n";
264:        $host = $TWiki::cfg{PROXY}{HOST};
265:        $port = $TWiki::cfg{PROXY}{PORT};
266:    }

I believe our proxy server was rejecting the query if the User-agent is not defined. Since this is defined in line 261 and not in line 263, I just copy/pasted the string.

OK

Duplicate of Item4124

Untar fails

Changes in Configure/UIs/EXTEND.pm:
63c63
<     } elsif ($ar !~ s!^.*Content-Type: application/x-gzip\r\n\r\n!!is) {
---
>     } elsif ($ar !~ s!^.*Content-Type: application/x-gzip.*\r\n\r\n!!is) {
88c88
<       } elsif ($ar !~ s#^.*Content-Type: application/zip\r\n\r\n##is) {
---
>       } elsif ($ar !~ s#^.*Content-Type: application/zip.*\r\n\r\n##is) {  

This was not removing the entire HTTP header, since the Content-Type field was not at the end (at least in my case). The trailing .* did the trick.

Duplicate of Item3885

File::Copy::move() cannot move directories across file systems

The move at Configure/UIs/EXTEND.pm:345 fails with the message:
Error: Failed to move file 'pub/TWiki/NatSkin' to /nfs/site/disks/wiki_base_1/test/TWiki-4.1.2/pub/TWiki/NatSkin: Is a directory
The code needs to be rewritten using File::Copy::Recursive or File::NCopy (the latter is not installed on our system).

Works smoothly if I go to the Unix side and do mkdir pub/TWiki/NatSkin. Although, configure doesn't seem to bother about dependencies :-(, I had to take care of each one separately (and TWiki:Plugins.NatSkin has a bunch).

Duplicate of Item3748

-- TWiki:Main/PankajPant - 22 May 2007

OK, I added the User-agent as you suggest.

Just a note for the future; can you please check for duplicates, otherwise I end up spending ages looking at problems that are already fixed; and can you please report bags in individual bug topics. It's impossible to track them when they are all crammed into one report.

CC

Shucks. It would have saved me a whole day of grief if I had seen those two before :-(.

I'll make sure I check up existing bugs in future ... this was my first.

-- TWiki:Main.PankajPant - 23 May 2007

Closing this since there are individual bug items for all 3 above.

KJL

ItemTemplate
Summary Bugs in installing extensions through configure (UI.pm and EXTEND.pm)
ReportedBy TWiki:Main.PankajPant
Codebase 4.1.2
SVN Range TWiki-4.1.2, Fri, 18 May 2007, build 13796
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:13855
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2007-05-26 - TWikiUserMapping_KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback