• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4124: Proxy support in CONFIGURE and Net.pm is incorrectly implemented

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configure Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Proxy support in CONFIGURE and Net.pm is incorrectly implemented in that, if TWiki::cfg{PROXY}{HOST} and TWiki::cfg{PROXY}{PORT} are present, the code does not insert an http "agent id" in the GET request. A lot of sites do not care -- but ironically twiki.org DOES care and rejects the request from CONFIGURE for a listing of available plugins to install.

The fix is simple: in lib/TWiki/CONFIGURE/UIs/UI.pm simply remove line 87 ($req = "GET http://$host:$port$path HTTP/1.0\r\n\r\n";). "$req" is actually defined prior to line 87 with a GET string that actually works.

I have been advised that the code in CONFIGURE was pulled from Net.pm, so the same code error likely exists there as well.

-- TWiki:Main/SteveRJones - 24 May 2007

The reason twiki.org and most 4.X based TWikis reject clients with no agent string is that I added this to the default apache config.

The reason is to prevent two twikis from including a topic from each other that includes a topic from each other ...

So when fixing this - add an agent string to configure but make sure not to add the same agent string to include (different or leave it at none like now). Otherwise we will have to protect against this new agent string and then we are back where we started.

-- TWiki:Main.KennethLavrsen - 24 May 2007

Duplicate of Item4113

CC

I will put this in Waiting for Release because then we get the seperate headline in the release note.

And then close the 4113 which contains 3 bugs.

KJL

As far as I can tell this issue has been addressed.

-- SteveRJones - 29 Aug 2007

ItemTemplate
Summary Proxy support in CONFIGURE and Net.pm is incorrectly implemented
ReportedBy TWiki:Main.SteveRJones
Codebase 4.1.2
SVN Range TWiki-4.1.2, Fri, 18 May 2007, build 13796
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor

Checkins

TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2007-08-29 - SteveRJones
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback