• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4165: Stringent IF syntax breaks templates

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The recent IF update: Some syntax which was undocumented, but would have worked with %IF previously, is now checked by the parser and rejected (unquoted named being treated as strings) breaks a lot of existing templates. Pages don't show at all because of errors.

-- TWiki:Main/ArthurClemens - 30 May 2007

I would like to ask developers to be very very careful with changing behaviour of TWiki. If you want to avoid this, plan ahead and create a solid syntax that does not need to be changed. This is exactly why I was trying to help define a solid TQL. (However, I gave up since I only got defensive reactions instead of a constructive dialog frown )

I suggest to restore the previous behaviour so that we can avoid breaking existing skins.

-- PTh

Arthur, could you tell me which pages? I see a problem with some edit pages, but it doesn't seem to be related to %IF.

Peter, the syntax for IF as documented is unchanged. The fact that the parser had a bug that allowed a specific undocumented syntax to pass without comment is the issue here. IIRC you are the one who first proposed normalising the syntax between search queries and IF, a feedback I took on board and executed on. I hope I have done it in such a way as to minimise the impact on users. What Arthur reports above is a bug in my change (or he simply needs to svn up).

CC

I had missed checking in one file during the change. I have checked all the pattern skin templates (they are richest in the use of IF) and have not found any errors.

CC

Thanks CC for the clarification.

-- PTh

ItemTemplate
Summary Stringent IF syntax breaks templates
ReportedBy TWiki:Main.ArthurClemens
Codebase

SVN Range TWiki-4.1.2, Fri, 18 May 2007, build 13796
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2007-05-31 - TWikiUserMapping_PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback