• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4217: PreferencesPlugin is not working any longer - either failing to save or barfing

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PreferencesPlugin Urgent Closed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

PreferencesPlugin is not working any longer - either failing to save or barfing

The plugin is still used in Main.TWikiPreferences. But the form it calls for is not in the Main web.

If you edit, and change something and then save, nothing is altered. The plugin looks like it is working but it is not changing any setting when saving.

When you copy the missing form from the Twiki web to the Main web the plugin fails with

Can't locate object method "renderFieldForEdit" via package "TWiki::Form" 

This is a default plugin distributed with TWiki and MUST work. And we cannot just remove it. Many people will probably use it even if we removed it from TWiki.TWikiPreferences.

So this is a release blocker.

-- TWiki:Main/KennethLavrsen - 06 Jun 2007

it is the refactoring of the Form code in SVN 13711 that broke this plugin.

Not a blame - just information.

It is bad that the plugin author used internal TWiki functions instead of using official API.

When official API does not meet the demand there are at least two things you can do.

  • Copy the code you miss into the plugin
  • Add a comment in the core code that a default plugin uses the function so refactorings happens in a way so you know you need to fix a plugin afterwards.

-- TWiki:Main.KennethLavrsen - 06 Jun 2007

This was set to "Being worked on" with no indication as to who is working on it. Flipped back to Confirmed until a committed fixer emerges.

CC

Fixed and added testcases, as well as extending it to suport editing without a form in place

CC

ItemTemplate
Summary PreferencesPlugin is not working any longer - either failing to save or barfing
ReportedBy TWiki:Main.KennethLavrsen
Codebase ~twiki4
SVN Range TWiki-4.1.2, Mon, 04 Jun 2007, build 14028
AppliesTo Extension
Component PreferencesPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14250
TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2007-06-23 - TWikiUserMapping_CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback