• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4335: TablePlugin: TWikiTables in TWikiLists generate invalid html

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TablePlugin Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Introduced by Item4294, SVN r14279.

You type:

   * list
     | table |
   * list

You get (currently):

  • list
table
  • list
That's the markup (currently):
<ul> <!-- open ul -->
  <li> list      
    <table> <!-- open table -->
      <tr><td> table </td></tr>     
  </li>
</ul> <!-- close ul ... OUTCH -->
</table> <!-- close table ... OUTCH -->
<ul>
  <li> list </li>
</ul> 

Browsers react differently on this markup not being nested properly.

The fix is:

--- lib/TWiki/Plugins/TablePlugin/Core.pm       (revision 14319)
+++ lib/TWiki/Plugins/TablePlugin/Core.pm       (working copy)
@@ -1358,7 +1358,7 @@
         $rowCount++;
     }    # foreach my $row ( @curTable )

-    $text .= $currTablePre . "\n" . CGI::end_table() . "\n";
+    $text .= $currTablePre . CGI::end_table() . "\n";
     _setDefaults();
     return $text;
 }

-- TWiki:Main/MichaelDaum - 06 Jul 2007

ItemTemplate
Summary TablePlugin: TWikiTables in TWikiLists generate invalid html
ReportedBy TWiki:Main.MichaelDaum
Codebase

SVN Range TWiki-4.1.2, Thu, 28 Jun 2007, build 14298
AppliesTo Extension
Component TablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14321
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback