• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4423: SpreadSheetPlugin calculations do not execute within CommentPlugin templates

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension CommentPlugin Enhancement Confirmed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Marked as Urgent because both CommentPlugin and SpreadSheetPlugin are default plugins. See also: TWiki:Support.DynamicDoubleBracketLink

Steps to Reproduce

1. add the following to UserCommentsTemplate

Add Checklist Item

%TMPL:DEF{PROMPT:checklist_table}%
%TABLE{ valign="top" }%
| Add Checklist Item ||||||||
| *Status* <br/> <input %DISABLED% type="hidden" size="16" name="clitem_id" value="%SERVERTIME{$year$month$day$hour$min$sec}%" />%N% | *To Do* <br /> <input type="text" size="30" name="to_do" value="" /> | *Comment* <br /> <input type="text" size="50" name="comment" value="" /> |  <input %DISABLED% type="submit" value="%button|Add New Entry%" /> <br/> %CALC{"$IF($EXISTS(%WEB%.%TOPIC%ChecklistItemState), [[%TOPIC%ChecklistItemState][maintain states]], )"}% |
%TMPL:END%

%TMPL:DEF{OUTPUT:checklist_table}%| %CLI{id="%URLPARAM{"clitem_id"}%"}% | %URLPARAM{"to_do"}% | %URLPARAM{"comment"}% |%POS:BEFORE%
%TMPL:END%

2. use the comment template as follows

%COMMENT{type="checklist_table"}%

3. observe the problem

The following appears in the template (instead of the result of the "if exists" test):

%CALC{"$IF($EXISTS(CheckListT…tItemState), maintain states, )"}%

-- TWiki:Main/KeithHelfrich - 27 Jul 2007

What on earth is %CLI? AFAIK that's nothing to do with either plugin, nor the core.

-- TWiki:Main.CrawfordCurrie - 27 Jul 2007

Hi Crawford, a %CLI is from the TWiki:Plugins.ChecklistPlugin. Does it's existence in the template mean that the bug is invalid ?

-- TWiki:Main.KeithHelfrich - 03 Aug 2007

The question is if you also have the bug when you do not have the %CLI in the template.

It is a bit of a task having to install ChecklistPlugin to verify your problem.

-- TWiki:Main.KennethLavrsen - 27 Aug 2007

Bug confirmed.

See Item4423Test

Release blocker? Borderline I would say.

-- TWiki:Main.KennethLavrsen - 27 Aug 2007

We have been discussing back and forth a few times on which tags CommentPlugin should expand up front and which it should delay.

As I remember it we have sometimes ended up in it being a feature request to be able to state explicitely which tags are wished expanded at comment time and which are not.

Not a release blocker, more of a feature request / wish for functionality. Should be discussed in a Codev topic imho.

-- TWiki:Main.SteffenPoulsen - 27 Aug 2007

I agree it is not a release blocker.

Steffen do we have a Codev topic that already covers this?

And to anyone - is there a workaround that Keith can use?

-- TWiki:Main.KennethLavrsen - 27 Aug 2007

TWiki:Plugins.CommentPluginDev has a little discussion and a few workarounds (along the lines of pre-calculating needed values and putting them in a variable up front).

-- TWiki:Main.SteffenPoulsen - 27 Aug 2007

ItemTemplate
Summary SpreadSheetPlugin calculations do not execute within CommentPlugin templates
ReportedBy TWiki:Main.KeithHelfrich
Codebase 4.1.2, ~twiki4
SVN Range TWiki-4.1.2, Thu, 19 Jul 2007, build 14438
AppliesTo Extension
Component CommentPlugin
Priority Enhancement
CurrentState Confirmed
WaitingFor

Checkins

TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r8 - 2007-08-27 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2023 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback