Item4510: Remove inline scripts

An oversight: if inline scripts are disabled some topics will give an error.

-- TWiki:Main/ArthurClemens - 27 Aug 2007

Note that this one is concerning if things work when {AllowInlineScript} is disabled in Configure (security tab).

The problem is that you get some error messages.

This bug item does not cover graceful fallback. If someone sees a script that does not fallback gracefully please raise a bug item on it.

Arthur volunteered to look at this so assigning to him. When fixed this goes to "Waitng for release" because it is also in 4.1.2

-- TWiki:Main.KennethLavrsen - 28 Aug 2007

I have replaced the red error message by an HTML comment. I have removed the inline script from pattern's WebTopicBar.

3 topics still have javascript:

• WebSearch
  
• WebSearchAdvanced
• TWikiRegistration

Those topics function as well without javascript. And without a red message the topics can be used without looking broken. -- TWiki.Main.ArthurClemens - 30 Aug 2007

I have removed the scripts from WebSearch and WebSearchAdvanced as well now. The script has been moved to pattern.js.

-- TWiki:Main.ArthurClemens - 02 Oct 2007

More work to do.

-- TWiki:Main.ArthurClemens - 05 Oct 2007

I eliminated all except one (oopslanguagechanged) from the default templates. I'm not confident to remove this last one.

That template is under scrutiny for possible removal. As it is not such a big problem if that script gets eaten, lowering this from Urgent to Normal, and marking for Arthur's attention.

CC

I have removed the script from that template. It still works.

-- TWiki:Main.ArthurClemens - 17 Dec 2007