Item4629: Cannot delRev any longer.

This is the error message

 Error saving topic
During save of Myweb.WebHome an error was found by the version control system. Please notify your TWiki administrator.

Can't use string ("KennethLavrsen") as a HASH ref while "strict refs" in use at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1179. 
at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1179 TWiki::Store::__ANON__() 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x8e40fb8)', 'HASH(0x91e0f20)') 
called at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1182 TWiki::Store::delRev('TWiki::Store=HASH(0x8d98aa4)', 'KennethLavrsen', 'Myweb', 'WebHome') 
called at /usr/local/apache2/twiki/lib/TWiki/UI/Save.pm line 473 TWiki::UI::Save::__ANON__() 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x9114f34)', 'HASH(0x92e9c44)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI/Save.pm line 481 TWiki::UI::Save::save('TWiki=HASH(0x8a32b3c)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI.pm line 159 TWiki::UI::__ANON__() 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x8a32d88)', 'HASH(0x92e7960)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI.pm line 197 TWiki::UI::run('CODE(0x8bbf9d8)', 'save', 1) 
called 

Go back in your browser and save your changes locally. During save of Myweb.WebHome an error was found by the version control system. Please notify your TWiki administrator.

Can't use string ("KennethLavrsen") as a HASH ref while "strict refs" in use at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1179.
at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1179 TWiki::Store::__ANON__()
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x8e40fb8)', 'HASH(0x91e0f20)') 
called at /usr/local/apache2/twiki/lib/TWiki/Store.pm line 1182 TWiki::Store::delRev('TWiki::Store=HASH(0x8d98aa4)', 'KennethLavrsen', 'Myweb', 'WebHome') 
called at /usr/local/apache2/twiki/lib/TWiki/UI/Save.pm line 473 TWiki::UI::Save::__ANON__() called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x9114f34)', 'HASH(0x92e9c44)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI/Save.pm line 481 TWiki::UI::Save::save('TWiki=HASH(0x8a32b3c)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI.pm line 159 TWiki::UI::__ANON__() 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 379 eval {...} 
called at /usr/local/apache2/twiki/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x8a32d88)', 'HASH(0x92e7960)') 
called at /usr/local/apache2/twiki/lib/TWiki/UI.pm line 197 TWiki::UI::run('CODE(0x8bbf9d8)', 'save', 1) called =

Go back in your browser and save your changes locally. 

-- TWiki:Main/KennethLavrsen - 14 Sep 2007

Look at this topic in raw view. It was created in IE.

Also - verbatim does not work. I marked the text as verbatim and saved but as can be seen verbatim is also broken in TMCE. Or at least it often does not work. (this extra text is added with comment plugin)

-- TWiki:Main.KennethLavrsen - 14 Sep 2007

There appears to be a paragraph with an "mce_keep" style around it. Never seen one of those before. Where did you paste the content from?

Note that after editing and saving again, the WysiwygPlugin has "healed" the topic. Need to go back to r1 for the testcase.

CC

The text was pasted from a plain text editor. Browser is IE6.

Same thing happens with any topic I edit in IE6. That is why I cannot test anything at the moment.

-- TWiki:Main.KennethLavrsen - 14 Sep 2007

PS to anyone reading this. Do not forget that this bug is oroginally about delRev.

-- TWiki:Main.KennethLavrsen - 14 Sep 2007 </verbatim>

Just edited this again in IE. Look at the many verbatims now

-- TWiki:Main.KennethLavrsen - 14 Sep 2007

Is this still a problem?

I can use /twiki/bin/edit/Main/WebHome?cmd=delrev without any problems.

Perhaps the steps needed to reproduce could be stated more explicitely.

-- TWiki:Main.SteffenPoulsen - 14 Sep 2007

I can now.

I got a revision deleted after having removed "use strict" as a try.

Look at Item4454 which I also posted a while ago.

I think it is the same bug. But not the same condition. Maybe my previous revision had another user as last editor or some stange username in the meta.

-- TWiki:Main.KennethLavrsen - 15 Sep 2007

Yes. I can reproduce it now. It actually does delrev but shows the error at the same time.

This is how I reproduced it. Not a normal user case. But can be. If a spammer has added some unwanted revisions and you have removed him as a user before you delRev topics this will happen.

Take a topic with several revisions.

Edit the topic with a file editor and change META:TOPICINFO{author="ValidUsername"

so that the ValidUsername is changed to some ransom characters.

Now do a delrev of the topic in TWiki and I will assume you see the error.

When fixing you can probably also close 4454. I am sure now it is the same bug.

-- TWiki:Main.KennethLavrsen - 15 Sep 2007

Hmm. I can reproduce it also with a valid user now.

-- TWiki:Main.KennethLavrsen - 15 Sep 2007

Again and again.

-- TWiki:Main.KennethLavrsen - 15 Sep 2007

Problem topic attached incl ,v file. Remember to rename it back to ,v

-- TWiki:Main.KennethLavrsen - 15 Sep 2007

It was a hangover from user objects.

CC