Item4667: Adding CGI::Session with distribution and enable Template login by default.

Think we should ship with CGI::Session disabled?

Set TemplateLogin on by default? (we've got a messy mixup atm - we start with no Loginmanager, but the default .htaccess is set for apacheauth)

I think TemplateLogin is sufficiently stable, and alot simpler to setup for our new users....

-- TWiki:Main/SvenDowideit - 19 Sep 2007

I think that

• Sessions should be enabled. TWiki works very bady without. People should really be pushed to install it and only run without if they really really have to
• One of the two login schemes should be enabled and Template is a fine choice. The default twiki_httpd_conf.txt is actually setup for Template. The ApacheLogin lines are commented out.

-- TWiki:Main.KennethLavrsen - 19 Sep 2007

The .htaccess.txt in bin is not. That I will fix right away. That should be consistant and default to Template.

-- TWiki:Main.KennethLavrsen - 19 Sep 2007

I have checked in the .htaccess,txt and twiki_httpd_conf.txt syncing. They are both setup for TemplateLogin now and the ApacheLogin stuff is included but commented out.

Did not touch the TWiki.spec file yet. We agree on the default login but should round off the the session discussion. I prefer that sessions are default on because I have very bad experience from the testing I have done with them off.

-- TWiki:Main.KennethLavrsen - 19 Sep 2007

mmm, 'very bad experience from the testing' needs more info - if its busted, it needs to be fixed - at the moment, CGI::Session isn't part of the TWikiRelease, and whenever I look at the rpm's they have un-necessary dependancies on Postgres - (though I've built a set that don't).

(I would like to have it on by default, but is you don't have CGI::Session, twiki's view script just gives you a blank screen, to error, nothing)

-- TWiki:Main.SvenDowideit - 20 Sep 2007

The very bad experience is that TWiki does not remember who I am and I have to authenticate again and again. Many users have reported the same. There may be some obscure and probably very unsafe IP address based alternative but nothing we want to ship as default. So either we require CGI::Session CPAN or we ship a TWiki that cannot remember who you are.

Does the CGI::Session lib contain any binary elements? Could it be in our mini CPAN lib in the distro? I think I did look at it and saw some binary dependency but I am not sure.

You know I often talk against having too many CPAN dependencies. But no rule or oppinion without exceptions and I have a very difficult time imagining using TWiki for anything serious without CGI::Session installed and used.

-- TWiki:Main.KennethLavrsen - 20 Sep 2007

Oh. And I assume that we all agree on Template as default so I will checkin that tonight. Then there is only the session thing open.

-- TWiki:Main.KennethLavrsen - 20 Sep 2007

Closing the bug to clean up. If someone can later find a way to include CGI::Session let us open a bug tracker for this. It will be 4.2.1 anyway.

-- TWiki:Main.KennethLavrsen - 21 Sep 2007

ok, CGI::Session will need some testing

If we ship just the perl modules, it works for us fine.... BUT if someone then installs the real cpan version of CGI::Session, we need to be sure TWiki will use that

looking at setlib.cfg, I think the $CPANBASE code works exactly that way -

-- TWiki:Main.SvenDowideit - 21 Sep 2007

<SvenDowideit_> the CPAN libs are added to the front of the @INC
<SvenDowideit_> can we change them to goto the end?
<SvenDowideit_> so that the system libs can over-ride what will over time age?
<SvenDowideit_> basically, I'm thinking if the user has _not_ specifically set CPANBASE
<SvenDowideit_> that the shipped CPAN goes to the end, only to be used _if needed_
<SvenDowideit_> so that its only in front for people that know a little more

Index: bin/setlib.cfg
===================================================================
--- bin/setlib.cfg      (revision 15078)
+++ bin/setlib.cfg      (working copy)
@@ -38,6 +38,7 @@
 }
 
 #    Path to local Perl modules
+my $defaultingCPANBASE = !defined($CPANBASE);
 $CPANBASE = "$twikiLibPath/CPAN/lib/" unless $CPANBASE;
 if ( -e $CPANBASE ) {
        require Config;
@@ -48,7 +49,11 @@
 
 # Prepend to @INC, the Perl search path for modules
 unshift @INC, $twikiLibPath;
-unshift @INC, @localPerlLibPath if defined @localPerlLibPath;
+if ($defaultingCPANBASE) {
+       push @INC, @localPerlLibPath if defined @localPerlLibPath;
+} else {
+       unshift @INC, @localPerlLibPath if defined @localPerlLibPath;
+}
 
 1;                             # Return success for module loading

-- SvenDowideit - 28 Sep 2007

i can't think of a reason not to move them to the end.

CC

done

-- SvenDowideit - 01 Oct 2007