• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4815: Wrong link to username of attachments from 4.1 topics

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Someone decided to change the format of the topics so the attachments get the login name instead of the Wikiname.

I did not notice this until I tried to install 4.2.0 beta2 at the office where we have login names different from wikinames.

It seems that in the META:FILEATTACHMENT in 4.1 was in the form user="Main.KennethLavrsen"

Now it is has become user="c12179"

The problem is when you upgrade from 4.1.2 to 4.2.0 all the old topics are of the old format. And on all the attachments we get links to non existing user topics and a ?-mark link that tries to create Main.Main.KennethLavrsen.

This is for sure a show stopper bug that needs to get fixed since it hits hard on anyone with login names that upgrades from earlier versions of TWiki.

To reproduce just place an old 4.1 topic with attachment in a 4.2 twiki.

-- TWiki:Main/KennethLavrsen - 14 Oct 2007

huh? This worked. There are many unit tests to make sure that it works, and Peter reported this exact problem and I added unit tests to cover it. I wonder what happened?

-- TWiki:Main.SvenDowideit - 17 Oct 2007

Where are these tests? I couldn't find them, but can reproduce Kenneth's observation.

-- TWiki:Main.HaraldJoerg - 17 Oct 2007

Addendum: Item2957 shows an interesting pattern of working and non-working user displays, both in the same attachment table. The raw texts hold Main.AndrewJones86 and Main.CrawfordCurrie, respectively. Given that both Kenneth and I have non-alphabetic characters in their logins, and it hits only Andrew Jones here, this might be a clue. On the other hand, in my SVN checkout, I've got a Main.Main.TWikiGuest in the attachment table.

-- TWiki:Main.HaraldJoerg - 17 Oct 2007

I wrote the unit tests for the TWiki::Users or TWiki::Func level, so I'm presuming that the re-surfacing of this is higher up ?

-- TWiki:Main.SvenDowideit - 18 Oct 2007

after adding a pile more tests, I found the problem. I'm not sure I like the side effects (if you have a . in the cUID, the code will assume its a webname, and remove it along the way. most of the problem is due to the removal of the TWikiUserMapping_ prefix, as there are lots of attempts at assuming what the unknown cUID refers to.

-- SvenDowideit - 24 Oct 2007

ItemTemplate
Summary Wrong link to username of attachments from 4.1 topics
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.3.0, Fri, 12 Oct 2007, build 15261
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:15405 TWikirev:15406
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback