• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4816: EditPreferences of Main.TWikiPreferences broken

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PreferencesPlugin Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

In TWikiRelease04x02 branch if you go to TWikiPreferences (the one in Main) - you must be logged in as admin to do this - and click the Edit Preferences button you get the correct change to a form based settings entry.

But try saving. Then you get a mysterious "This topic does not exist page that says: The topic 'Jump' you are trying to access does not exist, yet.

The URL is the preferences URL but I get this strange error.

In MAIN branch I get a

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.

Can't call method "renderForEdit" on an undefined value

It also seems someone removed the button from TWiki.TWikiPreferences. Maybe to not encourage editing the TWiki web. But someone changed something so that the plugin no longer works.

This plugin was the argument for deprecating and removing form based settings so it has to work. Therefore urgent release blocker.

-- TWiki:Main/KennethLavrsen - 14 Oct 2007

I know the root cause of this one and I have a fix coded.

Need to run some more testing and run unit tests before I check it in.

-- TWiki:Main.KennethLavrsen - 26 Oct 2007

I ended up spending a lot of time on this trying regex a fix. But it required a little code.

I found and fixed 3 bugs.

  • Preferences Plugin would also create fields inside html comment adding the inside the HTML comment. Result was that forms were mixed up and you ended up at a jump page. Now only visible fields become edit fields
  • The plugin had a problem with editing fields that were not defined in the template if a template is used.
  • And finally fixed the TWikiPreferences so it calls the form in TWiki web

Unit tests have been extended to catch the html comment bug

Tested that the plugin also works in 4.1.2

-- TWiki:Main.KennethLavrsen - 05 Nov 2007

Plugin uploaded to t.o

-- TWiki:Main.KennethLavrsen - 05 Nov 2007

ItemTemplate
Summary EditPreferences of Main.TWikiPreferences broken
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.3.0, Fri, 12 Oct 2007, build 15261
AppliesTo Extension
Component PreferencesPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:15484 TWikirev:15487
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback