Item4853: Does not support %EDITCELL

-- TWiki:Main/CrawfordCurrie - 18 Oct 2007

Does now.

CC

That's great to hear. Will test that as soon as possible.

-- TWiki:Main.FranzJosefGigler - 21 Oct 2007

Hm, tested it now on a TWiki 4.2 beta 2 installation. Getting multiple %EDITCELL entries when editing the following table wit EditRowPlugin.

Home:	Client list	List of Clients
Short:	ABC	* Short name of Client
Long:	A Brandnew Company	* Full name of Client
Note:	This is a brandnew company producing ...	Info about Client
Since:	2007-11-20	Client since
Page:	http://abc.com	Homepage
Phone:	+1(0)xxx xxxxxx	Phone number
		*...Mandatory

Will try it again on a beta 3 later.

-- TWiki:Main.FranzJosefGigler - 20 Nov 2007

Checked it on my (slow!) synology diskstation box running 4.2 beta 3 with the latest plugin version from twiki.org. Same problem! See for yourself at http://pfum.ath.cx/bin/view/Sandbox/BugsUserSandbox using BugsUser/pax as authentication pair. Edit and save the table twice and then look at the source. See the multiple EDITCELL entries?

-- TWiki:Main.FranzJosefGigler - 21 Nov 2007

Not good. Confirmed, and raised to Urgent.

CC

Fixed

CC

Hm, tested it on my beta 2 vmware debian box: doesn't multiply EDITCELL entries anymore okay, but doesn't save anything new in my test table at all anymore and that's NOT okay. Will test it on my beta 3 setup at home again later.

-- TWiki:Main.FranzJosefGigler - 23 Nov 2007

Sorry, it doesn't work. The cells get expanded, you can edit but if you want to save no chances are saved. See http://pfum.ath.cx/bin/rdiff/Sandbox/BugsUserSandbox?rev1=2;rev2=1

And there are these optical glitches (upper left corner should also contain an edit symbol (although the rows are labels and shouldn't be editable). It seems EditRowPlugin thinks there shall be a header but I don't want or need one. And in comparison to the EditTablePlugin the edit mode doesn't expand %COLOR% or other variables although they are used in label columns. But I guess that should be separate bug reports, right?

-- TWiki:Main.FranzJosefGigler - 23 Nov 2007

Thanks for testing, Franz.

It does work, but there's a constraint which doesn't exist with EditTablePlugin; columns marked as "label" or "row" cannot be overridden with an EDITCELL, as they are treated as read-only by the code. Since your example above specifies "label" type for all columns, the changes don't get saved. I had to balance the complexity of the code to deal with this special case, versus the utility of such columns. Given that this is likely to be a common special case, perhaps someone needs to invest in writing that code.

upper left corner should also contain an edit symbol - why? It's a header row, it's not editable. You specified headerrows=1, so you do want a header.

Expanding TWiki variables in read-only columns (such as labels) is a reasonable requirement. Yes, it should be a separate report.

CC

Thanks for clarfication. Brilliant as ever. Will find Found a workaround for the label issue. You're right about headerrows, my fault. EditTablePlugin is more forgiving in this case, but I guess that's actually less correct.

-- TWiki:Main.FranzJosefGigler - 25 Nov 2007