• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4879: configure not honoring $TWiki::cfg{ScriptUrlPath}

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Configuration Urgent Closed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

When setting

$TWiki::cfg{ScriptUrlPath} = '/what/ever/';

that is not honored by the 'configure' script. It is invoked properly, but produces a

<form ....action="configure" ...

'Next' button somewhere here

-- TWiki:Main/RobertBarta - 23 Oct 2007

The 'Next' action in configure is relative to the URL used to invoke the script. This is necessary so that configure can work before ScriptUrlPath is set.

It has always been this way. Can you please be more specific about exactly what problem this is causing you, and why you consider it to be Urgent?

CC

The problem emerges, when TWiki is run behind a reverse proxy. Whereas all content scripts honor the prefix, the configure script does not honor the prefix. When it is invoked with

http://www.whatever.org/dev/unstable/configure

It creates a form

<form method="post" action="/cgi-bin/twiki/configure">

and not

<form method="post" action="/dev/unstable/configure">

It is urgent, because web-based administration in a reverse proxy situation breaks.

-- TWiki:Main.RobertBarta - 28 Oct 2007

Please try commenting out the line that says action=>$scriptName in bin/configure and let me know if that cures it for you.

-- TWiki:Main.CrawfordCurrie - 29 Oct 2007

Ping - please, someone with a reverse poxy give feedback!

-- TWiki:Main.CrawfordCurrie - 22 Nov 2007

TWiki:Main.KoenMartens is going to verify

CC

I have tried to reproduce this with squid in reverse proxy mode, but did not see the invalid form action described in the bug. I did see a problem with the 'Return to configuration' link on the save page though, which i fixed by making that a relative link.

Robert, are you positive that the form action was invalid, and not the 'Return to configuration' link?

I could retry with varnish, apache in reverse proxy mode, oops or any one of the other reverse proxies out there, but i find it hard to believe that a wrong form action will be generated. The code does not leave much room for interpretation: it takes the script path, strips the path and uses only the filename for generating the form action, which is therefore always relative.

I'm setting this bug on Waiting for feedback again, but if we do not hear from Robert i propose to set it to Closed, since i have serious doubts about the posibility that the form action could be wrong.

-- TWiki:Main.KoenMartens - 15 Dec 2007

Additional note: i checked 4.1.2 as well as on the 4.2-branch. Same result.

-- TWiki:Main.KoenMartens - 15 Dec 2007

Apologies for being unresponsive, but I have abandoned TWiki.

> I have tried to reproduce this with squid in reverse proxy mode, ...

Gna. Reverse Proxy means that there is also URI rewriting going on. Such as with the the Apache ProxyPass, ProxyPassReverse directive.

This means that a reverse-proxied TWiki will have to adapt fully with the new URLpath. As I have written in my original bug report, it works perfectly for the ''normal'' scripts, but configure does not honor it and uses the generic /cgi-bin/twiki/configure action target in the form it creates.

> Please try commenting out the line that says
> action=>$scriptName in bin/configure and let
> me know if that cures it for you.

I faintly remember that I did that and that it worked.

Meta: And is there any way to make this comment window smaller? Say one line and one character only?

-- TWiki:Main.RobertBarta - 17 Dec 2007

Meta:

> Meta: And is there any way to make this comment window smaller? Say one line and one character only?

It's a wiki - feel free to use the edit button - we have a draggable edit window size now (whee!) smile

-- TWiki:Main.SteffenPoulsen - 17 Dec 2007

ItemTemplate
Summary configure not honoring $TWiki::cfg{ScriptUrlPath}
ReportedBy TWiki:Main.RobertBarta
Codebase 4.1.2
SVN Range TWiki-4.3.0, Fri, 12 Oct 2007, build 15261
AppliesTo Engine
Component Configuration
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16006 TWikirev:16008 TWikirev:16016 TWikirev:16017
TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r18 < r17 < r16 < r15 < r14 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r18 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback