• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4967: DBCachePlugin: don't die on non-txt or bad topic files polluting the data directory

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension DBCachePlugin Urgent Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

For example, topics without a META:TOPICINFO in it will have "a bad time" in dbcache. They will be ignored. Under normal circumstances, the TWiki engine will happily create the correct topic format. So this fix will protect normal users from file level or plugin based hostile topic edits, or something that polluted the data store in some way.

-- TWiki:Main/MichaelDaum - 14 Nov 2007

Another example of this is when the metadata is badly formed. Making a change so that the user is not confronted by these failures is a big advance!

-- TWiki:Main.LynnwoodBrown - 14 Nov 2007

We are encountering what appears to be this same bug. I believe it originated with an oddly named topic -- punctuation characters -- but I'm not certain. In any case, we can only cleanly save changes to any topic now by turning off DBCachePlugin. Some information as to how one can fix/purge/refresh the cache would be valuable. I'll be looking through DBCacheContrib to see if I can figure any of this out myself, but I don't really know when I'll have the time.

I'm re-opening this bug report for now.

-- DavidHoughton - 17 Mar 2008

Can you attach an example topic that produces a die, please?

-- TWiki:Main.MichaelDaum - 17 Mar 2008

I've cleaned them all out, but something like this seemed to do the trick:

SomethingWith::Colons

-- TWiki:Main.DavidHoughton - 18 Mar 2008

I should say that I cleaned them out by renaming the files then going through all the .txt and ,v files with vi and visually confirming then mass-replacing the offending characters. So I would rename SomethingWith::Colons to SomethingWithSlashColons then go through and look for meta-data in both SomethingWithSlashColons.txt and SomethingWithSlashColons.txt,v, make sure I wouldn't kill anything by doing a global search and replace, and then replace all :: s with Slash es.

Also, though I believe this fixed the problem, there was another person hacking away at our twiki simultaneously and he turned off the DBCachePlugin. I say I believe this fixed this problem because I believe I confirmed that the problem was gone before he turned the plugin off, but I'm not absolutely certain. Sorry if this is too hedged and vague.

-- TWiki:Main.DavidHoughton - 18 Mar 2008

This is fixed in DBCachePlugin-2.0 as far as I can say.

-- TWiki:Main.MichaelDaum - 29 Apr 2008

ItemTemplate
Summary DBCachePlugin: don't die on non-txt or bad topic files polluting the data directory
ReportedBy TWiki:Main.MichaelDaum
Codebase 4.1.2
SVN Range TWiki-4.3.0, Fri, 12 Oct 2007, build 15261
AppliesTo Extension
Component DBCachePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:15586
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2008-04-29 - MichaelDaum
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback